mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@it.uu.se>
To: Grant Coady <gcoady.lk@gmail.com>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/3] ATA Kconfig cleanup: hide ATA_SFF and add SATA/PATA menu items
Date: Sat, 16 Aug 2008 12:01:02 +0200	[thread overview]
Message-ID: <18598.42334.73411.476062@harpo.it.uu.se> (raw)
In-Reply-To: <qjoca411hv4hm25keq70ul5pnbi7747d13@4ax.com>

Grant Coady writes:
 > 
 > From: Grant Coady <gcoady.lk@gmail.com>
 > 
 > ATA Kconfig cleanup 1/3: Hide ATA_SFF, add PATA and SATA driver menu
 > enable items, and add dependency on the enabled PATA/SATA lines to 
 > all the ATA drivers except the PATA_PLATFORM items.

...

 > @@ -147,7 +166,7 @@
 >  
 >  config SATA_PROMISE
 >  	tristate "Promise SATA TX2/TX4 support"
 > -	depends on PCI
 > +	depends on ATA_SFF_SATA && PCI
 >  	help
 >  	  This option enables support for Promise Serial ATA TX2/TX4.

As I told you last time this came up, sata_promise drives both
sata and pata ports. One board has 4 pata ports, a couple have
two sata ports and one pata port, and a couple have 4 sata ports.
It's the same ata engine, however.

So at least give sata_promise the same treatment you gave ata_piix:

 > @@ -104,7 +123,7 @@
 >  
 >  config ATA_PIIX
 >  	tristate "Intel ESB, ICH, PIIX3, PIIX4 PATA/SATA support"
 > -	depends on PCI
 > +	depends on (ATA_SFF_SATA || ATA_SFF_PATA) && PCI
 >  	help
 >  	  This option enables support for ICH5/6/7/8 Serial ATA
 >  	  and support for PATA on the Intel ESB/ICH/PIIX3/PIIX4 series
 > @@ -114,7 +133,7 @@

I suspect sata_via will want this too.

/Mikael

  reply	other threads:[~2008-08-16 10:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-16  5:15 Grant Coady
2008-08-16 10:01 ` Mikael Pettersson [this message]
2008-08-16 10:32   ` Alan Cox
2008-08-17  4:20     ` Jeff Garzik
2008-08-18  1:47     ` [PATCH] ATA Kconfig cleanup: sort the driver list and modify some text Grant Coady
2008-08-18  8:56       ` Alan Cox
2008-08-20 23:27       ` Krzysztof Halasa
2008-08-21  0:16         ` Grant Coady
2008-08-21  0:49           ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18598.42334.73411.476062@harpo.it.uu.se \
    --to=mikpe@it.uu.se \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gcoady.lk@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®