From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com
Subject: Re: [PATCH] checkpatch: add --fix option for INCLUDE_LINUX
Date: Sat, 21 Nov 2020 12:05:22 -0800 [thread overview]
Message-ID: <185d4505b35be4b9d039f430b3f95e7c33ed6a49.camel@perches.com> (raw)
In-Reply-To: <20201121161706.104631-1-dwaipayanray1@gmail.com>
On Sat, 2020-11-21 at 21:47 +0530, Dwaipayan Ray wrote:
> Provide fix option to INCLUDE_LINUX check to replace asm
> includes.
>
> Macros of type:
> #include <asm/percpu.h>
>
> are corrected to:
> #include <linux/percpu.h>
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -5468,8 +5468,11 @@ sub process {
> CHK("ARCH_INCLUDE_LINUX",
> "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
> } else {
> - WARN("INCLUDE_LINUX",
> - "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
> + if (WARN("INCLUDE_LINUX",
> + "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr) &&
> + $fix) {
> + $fixed[$fixlinenr] =~ s/\<asm\/$file\>/\<linux\/$file\>/;
$file can include a slash.
e.g.: arch/arm/kernel/atags_parse.c:#include <asm/mach/arch.h>
Probably simpler to use /Q /E quoting.
next prev parent reply other threads:[~2020-11-21 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 16:17 Dwaipayan Ray
2020-11-21 20:05 ` Joe Perches [this message]
2020-11-21 20:31 ` Dwaipayan Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=185d4505b35be4b9d039f430b3f95e7c33ed6a49.camel@perches.com \
--to=joe@perches.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®