From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754566AbdGUP4g (ORCPT ); Fri, 21 Jul 2017 11:56:36 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:25618 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbdGUPzE (ORCPT ); Fri, 21 Jul 2017 11:55:04 -0400 Subject: Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe To: Keerthy , David Miller CC: , , , , , , References: <1500550192-6550-1-git-send-email-j-keerthy@ti.com> <5259f0e7-cc5d-35c9-8f09-94cf7b40f653@ti.com> <20170720.152831.802536956243282259.davem@davemloft.net> <0a5cdde6-5898-8f8c-5c56-d47fa9513958@ti.com> From: Grygorii Strashko Message-ID: <185e1781-d9b5-226d-2dde-26faaec7198d@ti.com> Date: Fri, 21 Jul 2017 10:55:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.59.147] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/20/2017 11:45 PM, Keerthy wrote: > > > On Friday 21 July 2017 04:14 AM, Grygorii Strashko wrote: >> >> >> On 07/20/2017 05:28 PM, David Miller wrote: >>> From: Grygorii Strashko >>> Date: Thu, 20 Jul 2017 11:08:09 -0500 >>> >>>> In general patch looks good to me, but it's really unexpected to >>>> receive IRQs while CPSW is probing ;( >>> >>> This is a poor expectation. >>> >>> Boot loaders and other entities can leave the device in any state >>> whatsoever. >>> >>> Furthermore, enabling an IRQ whose handler cannot properly execute >>> without crashing is wrong fundamentally. All data structures and >>> state must be set up properly before the IRQ is requested. >>> >>> Therefore this patch is correct and I will apply it. >>> >> >> Thanks. Agree (it just has never triggered before, so I meant - unexpected >> from current driver code point of view ;(). >> And I'm just worry that it might not be enough :(, especially for am335x. > > I tried nfs boot on am335x-evm with this patch and it boots fine for me. > Thank you Keerthy, I've also simulated and tested it on am335x and dra7 and see networking working and no crashes. -- regards, -grygorii