From: David Rientjes <rientjes@google.com>
To: Josh Don <joshdon@google.com>
Cc: Madadi Vineeth Reddy <vineethr@linux.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] sched/debug: Remove need_resched ratelimiting for warnings
Date: Thu, 9 Jan 2025 16:22:52 -0800 (PST) [thread overview]
Message-ID: <185e7b11-36aa-ffa8-7556-70a2840bd3b6@google.com> (raw)
In-Reply-To: <CABk29Nvtje0WB=HC=4UStpk0x3Fo84FjkgAQExpotDUBpxVDog@mail.gmail.com>
On Thu, 9 Jan 2025, Josh Don wrote:
> > Otherwise, please take a look, is this what you had in mind?
>
> I'm realizing now that we'll end up getting multiple splats for a
> single very long stall (one per the warning threshold). We could fix
> that by using a magic number rather than 0 here (such as U64_MAX), and
> then teach resched_latency() to bail out on this value.
>
Ack, ok. I'll drop this patch because I see that there are existing users
(at least one NVMe library) that cares about tuning both of these values
with what appears to be some amount of thought:
/sys/kernel/debug/sched/latency_warn_once=0
/sys/kernel/debug/sched/latency_warn_ms=16
and the intent was not that they get excessive output that they don't need
or aren't expecting. Thanks for looking at this!
prev parent reply other threads:[~2025-01-10 0:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <77e42990-0ea3-fc53-8051-6856a92ad4d0@google.com>
2025-01-06 20:39 ` David Rientjes
2025-01-07 18:14 ` Madadi Vineeth Reddy
2025-01-07 20:15 ` David Rientjes
2025-01-07 20:45 ` Josh Don
2025-01-09 17:59 ` David Rientjes
2025-01-09 18:53 ` Josh Don
2025-01-10 0:22 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=185e7b11-36aa-ffa8-7556-70a2840bd3b6@google.com \
--to=rientjes@google.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vineethr@linux.ibm.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®