From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161920AbdAEWEV (ORCPT ); Thu, 5 Jan 2017 17:04:21 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:53081 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754466AbdAEWEC (ORCPT ); Thu, 5 Jan 2017 17:04:02 -0500 From: Arnd Bergmann To: Raviteja Garimella Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Felipe Balbi , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-usb@vger.kernel.org Subject: Re: [RFC 0/1] Platform driver support for 'amd5536udc' driver Date: Thu, 05 Jan 2017 23:03:08 +0100 Message-ID: <1861880.7pouM4E6RB@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1483604597-26160-1-git-send-email-raviteja.garimella@broadcom.com> References: <1483604597-26160-1-git-send-email-raviteja.garimella@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:D070Uj9/P3WnlguzUwoLWabyXyTpvt8JFViWzw9c93D8X2VVVnN y4seN31421nNBRvVaN6c2zxwDbQf3J7JsmpykTIRCMvv5qxNECI+mzOSQruGRZo3d9IzpLJ JJHFBnl5IOW6xBJUFSpMEHw4dqLweUQOSjqpzuQqL+mcEWkTH4WRkfahVFaQM7bhupM9vUn HnVEbqHHh29eX6xgxK0yg== X-UI-Out-Filterresults: notjunk:1;V01:K0:NWb6q6e4UQA=:yjaEjQ7BTJewTB7stS9nMs nZuF9o6A7TZF6DyiTO2hnSqxr2xyzbKRrN4Hd4SYl3nrsZ5o0KcJY7wmu7KVzB/uSiXLAvudS y/zp5KQyhMssOeqmESBViBhVJL6snG/XhbFo64H9pRlvgf/3PaZV3JuHpEKpMHNm/6HvidF7t K0oiWwp27qgX2kOaST5mLMIvp4mZwjhvDSMF0zWqmlEu5umzwHsfP5B5wJO3kVCGwzUcHi92u Bwe48HlRsNc0+C9+zowdp4L7sW3UXWTFij6Y+CSPQAq8y1d/Ai2kn+kfTKds/NvTtWn5veoy5 G+DlovewGOFzv1Ilb8FVjAsJAGbOT7Z/1bAk8PWc0cVVP/DjLNnh+sa7BrDTsmuhEYyW8N3DS SxG0skC5vsVb5J2QEh4PA7edWmV6qhG3QyTs8rR9YHAK/iZmbQ14AhS3xQtRpPI14+2ipM9Pf XDPsJGgJiJUIQq7aPai89299cKJF9YMncVD+3fQAp55gNnrQnyrazeIjYpfBWuf8V+8UQj56M QGbQD6j1qflNO6V/sDTjgn+B07Jg+0+emSZ7OE0NihM6V3lGiLtsz+mLLWYlXr4o/HzH6rkxz 0GLmdW8yJwMJiWaGL5Pw2HDW3Z6H4hgAIecFIo6hF0/s+O06PIR1H1SfbZU00ZdNT2z23rXpA 1Bezxy75pNM5qgRf+wswiRA1e1pkxidYdorN511DfVVlOAo1MwTqMWVyRDQ7SYHlMhRp1WJLU FTAYUMth1IuqAfBZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, January 5, 2017 1:53:16 PM CET Raviteja Garimella wrote: > The UDC is based on Synopsys Designware core USB (2.0) Device controller > IP. ... > This is a request for comments from maintainers/others regarding approach > on whether to have 2 different drivers (one each for AMD and Broadcom) > with a common library (3 files in total), or have a single driver like > it's done in this patch and have the driver filename changed to some > common name based on ther underlying IP, like snps_udc.c. I have not looked at the code at all, so sorry for my ignorance, but isn't the IP block you describe the one that drivers/usb/dwc2/ is for? Could you add support for the Broadcom hardware there instead? Arnd