mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	x86 <x86@kernel.org>, "Jiri Koshina" <jikos@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: PM: Make APM idle driver initialize polling state
Date: Tue, 06 Feb 2018 19:02:58 +0100	[thread overview]
Message-ID: <1862424.1bTBpgPzTf@aspire.rjw.lan> (raw)
In-Reply-To: <20180206163134.GO5453@intel.com>

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Update the APM driver overlooked by commit 1b39e3f813b4 (cpuidle: Make
drivers initialize polling state) to initialize the polling state like
the other cpuidle drivers modified by that commit to prevent cpuidle
from crashing.

Fixes: 1b39e3f813b4 (cpuidle: Make drivers initialize polling state)
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 arch/x86/kernel/apm_32.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-pm/arch/x86/kernel/apm_32.c
===================================================================
--- linux-pm.orig/arch/x86/kernel/apm_32.c
+++ linux-pm/arch/x86/kernel/apm_32.c
@@ -2389,6 +2389,7 @@ static int __init apm_init(void)
 	if (HZ != 100)
 		idle_period = (idle_period * HZ) / 100;
 	if (idle_threshold < 100) {
+		cpuidle_poll_state_init(&apm_idle_driver);
 		if (!cpuidle_register_driver(&apm_idle_driver))
 			if (cpuidle_register_device(&apm_cpuidle_device))
 				cpuidle_unregister_driver(&apm_idle_driver);

  parent reply	other threads:[~2018-02-06 18:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 16:27 [PATCH] Revert "cpuidle: Make drivers initialize polling state" Ville Syrjala
2018-02-04  9:12 ` Rafael J. Wysocki
2018-02-04  9:18   ` Rafael J. Wysocki
2018-02-05 14:04     ` Ville Syrjälä
2018-02-05 17:56       ` Rafael J. Wysocki
2018-02-06 16:31         ` Ville Syrjälä
2018-02-06 18:00           ` Rafael J. Wysocki
2018-02-06 18:02           ` Rafael J. Wysocki [this message]
2018-02-06 18:26             ` [PATCH] x86: PM: Make APM idle driver initialize polling state Ville Syrjälä
2018-02-07  9:20               ` Rafael J. Wysocki
2018-02-07 14:00                 ` Ville Syrjälä
2018-02-12  9:21             ` [PATCH] PM: cpuidle: Fix cpuidle_poll_state_init() prototype Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1862424.1bTBpgPzTf@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®