From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751866AbdBAKBN convert rfc822-to-8bit (ORCPT ); Wed, 1 Feb 2017 05:01:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17478 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbdBAKBJ (ORCPT ); Wed, 1 Feb 2017 05:01:09 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20170131165537.GC23970@htj.duckdns.org> <17591.1485935811@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, Linux Kernel Mailing List , linux-arch@vger.kernel.org, Tejun Heo , dougmill@linux.vnet.ibm.com Subject: Re: [GIT PULL] percpu fix for v4.10-rc6 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <18627.1485943258.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Wed, 01 Feb 2017 10:00:58 +0000 Message-ID: <18628.1485943258@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 01 Feb 2017 10:01:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > The return value isn't the value of the atomic variable. > > The return value is whether the increment happened or not (ie the "was it not zero and > could be incremented" part?) Okay, fair enough. I was thinking of it as atomic_long_inc_return() - which obviously it isn't. David