From: Paul Mackerras <paulus@samba.org>
To: David Miller <davem@davemloft.net>
Cc: david-b@pacbell.net, James.Bottomley@hansenpartnership.com,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
alessandro.zummo@towertech.it
Subject: Re: [PATCH] fix RTC_CLASS regression with PARISC
Date: Tue, 9 Sep 2008 11:22:48 +1000 [thread overview]
Message-ID: <18629.53224.103107.523514@drongo.ozlabs.ibm.com> (raw)
In-Reply-To: <20080908.164427.216880550.davem@davemloft.net>
David Miller writes:
> int update_persistent_clock(struct timespec now)
> {
> struct rtc_device *rtc = rtc_class_open("rtc0");
>
> if (rtc)
> return rtc_set_mmss(rtc, now.tv_sec);
>
> return -1;
> }
>
> and that should handle this NTP shouldn't it?
Yes as long as your rtc set functions don't need to sleep, since
update_persistent_clock is called at interrupt level. Some powerpc
systems have their RTC at the far end of an I2C bus, and the I2C
access routines can sleep.
Paul.
next prev parent reply other threads:[~2008-09-09 1:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 15:53 James Bottomley
2008-09-08 18:19 ` David Brownell
2008-09-08 18:39 ` James Bottomley
2008-09-08 19:13 ` David Brownell
2008-09-08 20:28 ` James Bottomley
2008-09-08 21:29 ` David Brownell
2008-09-08 21:35 ` David Miller
2008-09-08 23:00 ` James Bottomley
2008-09-08 23:04 ` David Miller
2008-09-08 23:23 ` James Bottomley
2008-09-08 23:32 ` David Brownell
2008-09-08 23:43 ` David Miller
2008-09-08 23:29 ` David Brownell
2008-09-08 23:44 ` David Miller
2008-09-09 0:55 ` David Brownell
2008-09-09 2:52 ` David Miller
2008-09-09 3:17 ` David Brownell
2008-09-09 3:51 ` David Miller
2008-09-09 4:14 ` David Brownell
2008-09-10 21:04 ` Andrew Morton
2008-09-10 21:09 ` Randy.Dunlap
2008-09-10 21:19 ` David Brownell
2008-09-10 21:20 ` David Miller
2008-09-10 21:36 ` David Brownell
2008-09-10 21:40 ` David Miller
2008-09-09 1:22 ` Paul Mackerras [this message]
2008-09-08 21:37 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18629.53224.103107.523514@drongo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=alessandro.zummo@towertech.it \
--cc=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®