From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 319AD3BD638 for ; Mon, 23 Mar 2026 17:55:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774288540; cv=none; b=b+R3avalxNlhB0Ka1CUMQpAw+vLZcHVOTbBqCzy8s+3pXqhk99mHqQYQ6052imqe9OZo3njenc7gqZ5035wXeHCKtFt7trfb/vL9Wk5+2yDfOlCJcakCnVK+4v3oBsmf/CL8zf8HQT8ZjKOWnK59HXzPc+q8zqgslgujv91/nOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774288540; c=relaxed/simple; bh=J0OvGpC1raK6cri4IDVjajFKeyPNGWrCZpb1ISzOVsM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RoSqKdC+NQ93bl0y8vv+9ntztN7oYCs8cNWk/kmEuXFCpwGgVDif4GJHCHMw3dW2VZtfJNH2Fkl77Yg9S0SYeZJnda2pC16sXfDUTbqKdrI6YmDC+Yrm1JbUh275LYvaRDP21s/JWTztK8Zc3xp72ogvcUU393OaY5gJpgibGiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BaNL/OeM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eLfW1Zjc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BaNL/OeM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eLfW1Zjc" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NHquaV3934989 for ; Mon, 23 Mar 2026 17:55:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S+/K3Ay6UwXU3b+2kgmj7HuQL43oNjZ4mR3zsbDc9Bw=; b=BaNL/OeMncP2SQ1j 4oEPmOmV4KFJKU0uNZ8aUBhFwpE91EvqRjUhbDdz1JgX14DD03JrGpjKwZpjpBn8 o33OCigheY9EzQLs/BzKwiyi5C2JyfRWSaZwwtaOWeX3pKtS1Qku64cobByn3+9b YwcPODlCjZbX3U2aPbo/dZNZoFnR0ihu54CTnL4Io8aKnvA8jbCcPUQvXd6v3spa mBqwWpAHCIS4evLnyXr4wj7RwBXkeYn6qisC3sHDX8JTgIksQbONQL7cVrc7Lmtf nFKSPMQYfzQk2foGVl78KlG9q0S4HtsB4kvlr2tx1nQhGytyI0zjeyIP67OVwdhm DFpxTw== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d37a0gr6j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 17:55:38 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82a73ec7290so1810125b3a.1 for ; Mon, 23 Mar 2026 10:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774288538; x=1774893338; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S+/K3Ay6UwXU3b+2kgmj7HuQL43oNjZ4mR3zsbDc9Bw=; b=eLfW1Zjcu1GuQaaz/ygP88OMVGqVx5/8jvGKKNd/z4ewBzg0lu62EyYVq4aT/i/LxC wIjcucAtolujktn0bCnW7pHR+z59Os+lO2NKlVP7vznjDoB9g6skdNWPIPz2fovOvm03 cLwO/Ip7Kne2WLne/cuYwnlTCfb8VgQkqNch4mHWwePo17xfwVR8X/eYPK7fPgmC+mrb 9AkCb0S2Suk1H5S59rPQJPyuvY3euEVSmVjEZH3YJac6cF37QpeVb9AYEuEa1KEC7AFp B3RwViH1z78McEwAqx+EsBWsd2FwlQJsQcfLxWDJ/x9gaXo9nuij1wdFzsiOIftIoGO5 WDHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774288538; x=1774893338; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S+/K3Ay6UwXU3b+2kgmj7HuQL43oNjZ4mR3zsbDc9Bw=; b=dEEA08CHnAQXRnVYhMiA7KlBYWP68Fcc8DRqiB1yOEOAoa+1fTqlfTDv0eWKYJIOND AD0YXySU+Cd/o0h3GHLP7iAqx0ixp4nWKUeSLN9WXDqRPZoHUiYZW+J+ME/ACAJF+5pU piIke6NZ9yBrO/TUMddgBQDXYFhKAWietCCAKhbK1ZbtGtzaKOhLpj6jdSgNk+D7nD8V D3uJ+cZ9xGqeyI/hq+AnQVdVVFKpkRP2Vyi5e2aKbFYC//JuUlaGCDmyteza+OYVenEO 20qjYb2ddaY8vCe8pK+2TG0gWAYO3ykXbcsZIpHwT+XpMmkKSEzIA52/JWJ9GM8n6sNI yCCA== X-Forwarded-Encrypted: i=1; AJvYcCWRxtXzhJg9ew03QTas6n9OWoCwzopKD81mRFZLp6DOAFYdXbSPAOE9q2vw7til59Wy1sAoThChJ4C6elg=@vger.kernel.org X-Gm-Message-State: AOJu0YxjSeYsToBHsyvsuTT7YfXuKc1OcPyFYqBPy0m1KqZC0DPwLUw4 mr1ex6FfrkfXJiBe35IJjEClAzrXiZx1ynvrnD+eEZcBZ6ChYvHHCmM2vKSvQLROcio5ilaHm82 IiT7r6JobOwQY1IrokeGv+Z20CYXd1LuiP0KrjsNrImnvgppWdswYPKvtFAzvQTMXkc0= X-Gm-Gg: ATEYQzwuwqJ64dZ6YDboYGOO0QGBfn0iGRXtdsWzDt42M2y/PwnBt6gnZw33xzNdCoO ppWutvWAN7E8lZQOLLC0TwLNjhT5aZEzPIZkoTAvb2Twjmnf8YGr4hoUPnygZt8luA9zsrJgrpJ itbXQNCZSqg4z1QzoCPys5AlhZU+55p/Gl1Psq3tlv1p1da8CKD/dzFDxRBXQEkY6CW1qSptLqn C5lzrrd2FhO2dmUZvrWlPDtitR1CDDEeaKzwWHPo7PuesSGfNI/Co4SXD5+FB18My2CavkmyaHX KzLY9zUivqIAec+BNHzseIh2U36UtfTGwISP+q+dPpcQag1nCImpSbYoKT4mSS5INpEUFgyeny1 CM+b5cUsnkA8/sujanhnqTo64rebriJgPcoU+45i2MUJLWSI= X-Received: by 2002:a05:6a00:21d5:b0:82a:17b8:1474 with SMTP id d2e1a72fcca58-82a8c233026mr10579449b3a.1.1774288537895; Mon, 23 Mar 2026 10:55:37 -0700 (PDT) X-Received: by 2002:a05:6a00:21d5:b0:82a:17b8:1474 with SMTP id d2e1a72fcca58-82a8c233026mr10579426b3a.1.1774288537393; Mon, 23 Mar 2026 10:55:37 -0700 (PDT) Received: from [192.168.1.12] ([106.222.230.237]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b04222f42sm11959100b3a.61.2026.03.23.10.55.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 10:55:37 -0700 (PDT) Message-ID: <1862c582-0e7c-431b-a5da-684af2febc95@oss.qualcomm.com> Date: Mon, 23 Mar 2026 23:25:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/a6xx: Add missing aperture_lock init To: Rob Clark , dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , open list References: <20260323161603.1165108-1-robin.clark@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <20260323161603.1165108-1-robin.clark@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=GIIF0+NK c=1 sm=1 tr=0 ts=69c17e9a cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=WRfdsTvTEh9BIu3+I5rxZw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=HBqI_kkDSLXZieHAmgUA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDEzMiBTYWx0ZWRfXxB0xpx7erkxO XDWf/lYyEbw67JF6GC7YOt7zmaIcEeEDxrHna7RqiigTdsbfgS1oarJoveQFHakVOqpsBa2evi1 MdCGJjF4kTEJuUiuDoCR2Am/NMdqHrNncRX/S6Q7jQ4h1NEFhmtN/q4EyusR2hH+G+khzjnHKB5 5bX9VDclFS/9wzBwI/ngwy5wqCsrA0vhIg3vgNrvYgQ7kbF8+agcAR9ju+wWReJOA3qsZELgOC2 e1jwf2JYxldWB4r7mvR/9oa1/n5DjHKV9EivB3YNfi2JoqIIMgEnnCBn8XvEa2o1s3/iQY+8GxN aRiY6h2nZMceMdQmfo2zIccYdkpvnwSDIHSgkagblRfSf3ezvublCVlJL39ORs04JXcajy0PKzF 089f8GTPywSjFHHO1cqjRR5ccbezlecWG9YcOd5joh/JQLUSCUXlOYltgUPKp736YtsXtgniK6g tt9TmgLtdBy2ulBFRDA== X-Proofpoint-GUID: e2_oxsMLY7gJyhOY_mjuz62RaYgKfint X-Proofpoint-ORIG-GUID: e2_oxsMLY7gJyhOY_mjuz62RaYgKfint X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230132 On 3/23/2026 9:46 PM, Rob Clark wrote: > Looks like this was somehow missed when introducing gen8 support. > > Fixes: 288a93200892 ("drm/msm/adreno: Introduce A8x GPU Support") > Signed-off-by: Rob Clark Reviewed-by: Akhil P Oommen -Akhil. > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index 2129d230a92b..a00215b7bd1e 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -2656,6 +2656,7 @@ static struct msm_gpu *a6xx_gpu_init(struct drm_device *dev) > gpu = &adreno_gpu->base; > > mutex_init(&a6xx_gpu->gmu.lock); > + spin_lock_init(&a6xx_gpu->aperture_lock); > > adreno_gpu->registers = NULL; >