From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BB6AC433DB for ; Wed, 30 Dec 2020 06:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48635207B0 for ; Wed, 30 Dec 2020 06:29:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726511AbgL3G31 (ORCPT ); Wed, 30 Dec 2020 01:29:27 -0500 Received: from smtprelay0057.hostedemail.com ([216.40.44.57]:40978 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726363AbgL3G30 (ORCPT ); Wed, 30 Dec 2020 01:29:26 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 592CB18029210; Wed, 30 Dec 2020 06:28:45 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: music26_4715adf274a2 X-Filterd-Recvd-Size: 1768 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA; Wed, 30 Dec 2020 06:28:43 +0000 (UTC) Message-ID: <1863fac248a37a92d9bacc4992caafecdcdac0dc.camel@perches.com> Subject: Re: [PATCH] liquidio: style: Identical condition and return expression 'retval', return value is always 0. From: Joe Perches To: YANG LI , davem@davemloft.net Cc: kuba@kernel.org, dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 29 Dec 2020 22:28:42 -0800 In-Reply-To: <1609308450-50695-1-git-send-email-abaci-bugfix@linux.alibaba.com> References: <1609308450-50695-1-git-send-email-abaci-bugfix@linux.alibaba.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-12-30 at 14:07 +0800, YANG LI wrote: > The warning was because of the following line in function > liquidio_set_fec(): > > retval = wait_for_sc_completion_timeout(oct, sc, 0); >     if (retval) > return (-EIO); I presume abaci is a robot Perhaps also the robot could look for code immediately above this like: oct->props[lio->ifidx].fec = var; if (resp->fec_setting == SEAPI_CMD_FEC_SET_RS) oct->props[lio->ifidx].fec = 1; else oct->props[lio->ifidx].fec = 0; where a location is immediately overwritten. so the line oct->props[lio->ifidx].fec = var; could be highlighted and perhaps removed and also perhaps the second test and set block could be written oct->props[lio->ifidx].fec = resp->fec_setting == SEAPI_CMD_FEC_SET_RS;