From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18A17C197A0 for ; Fri, 17 Nov 2023 01:46:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345639AbjKQBq5 convert rfc822-to-8bit (ORCPT ); Thu, 16 Nov 2023 20:46:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345614AbjKQBqz (ORCPT ); Thu, 16 Nov 2023 20:46:55 -0500 Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 696FF195 for ; Thu, 16 Nov 2023 17:46:51 -0800 (PST) Received: from omf04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 00C28807EB; Fri, 17 Nov 2023 01:46:49 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA id A6CC420023; Fri, 17 Nov 2023 01:46:47 +0000 (UTC) Message-ID: <1868fc850a1ea5e51c833b68aacce120ad738ab7.camel@perches.com> Subject: Re: [PATCH] checkpatch: do not require an empty line before error injection From: Joe Perches To: Sergey Senozhatsky , Andy Whitcroft , Andrew Morton Cc: Dwaipayan Ray , Lukas Bulwahn , linux-kernel@vger.kernel.org Date: Thu, 16 Nov 2023 17:46:46 -0800 In-Reply-To: <20231109075147.2779461-1-senozhatsky@chromium.org> References: <20231109075147.2779461-1-senozhatsky@chromium.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Stat-Signature: d8ko5x4sjjiayy6fdqr88chxrbt81e4x X-Rspamd-Server: rspamout05 X-Rspamd-Queue-Id: A6CC420023 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/sKizmrO9gKq0Ar8O8bFe56cdGutLrTIc= X-HE-Tag: 1700185607-602356 X-HE-Meta: U2FsdGVkX19+k6GOXjvd9Krdnir1X07UxM2QE+jzwVqKeEsBjjNxbN9JJAfdOS3gf6MUwC3kqxk87uSfoX97eez7Sl7GpmnFXdn+PR269aoHUB0h3C/yoBNMCjuRN4GMurEHLmWhEX5U4T7dqOWFByRkriqQ8RNIJze+jYcJLB7IW1iMjEGWCfcuAbymml6o+E5Kgk42VJY7nbHjrd2lYDUee03Pk+AGujMt8fNxVEvgAgY30cXytflyQR//HLgTkXUt9ARsMsOZBUfk3l6jTYZLowTYmLwQccDoq/bYpToYNpHAHTawFDD0wIkWaO/qfyWlgFOxUj+CyvtsmzhKXR1tuUzdSsO4BAwDPSBXjc43ZiXfYp+mIEkEjpQyQ5gFcU7Hr0nnupVUKruZ8B67Co2GWgKseCXPn48+vRUJJPFkg//M4RdfZMULS02Uvmyi Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2023-11-09 at 16:51 +0900, Sergey Senozhatsky wrote: > ALLOW_ERROR_INJECTION macro (just like EXPORT_SYMBOL) can immediately > follow a function it annotates. > > Signed-off-by: Sergey Senozhatsky Acked-by: Joe Perches > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 25fdb7fda112..a94ed6c46a6d 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -4054,7 +4054,7 @@ sub process { > if ($prevline =~ /^[\+ ]};?\s*$/ && > $line =~ /^\+/ && > !($line =~ /^\+\s*$/ || > - $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param)/ || > + $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param|ALLOW_ERROR_INJECTION)/ || > $line =~ /^\+\s*MODULE_/i || > $line =~ /^\+\s*\#\s*(?:end|elif|else)/ || > $line =~ /^\+[a-z_]*init/ ||