From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F1CC433F5 for ; Wed, 23 Feb 2022 18:40:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244013AbiBWSkf (ORCPT ); Wed, 23 Feb 2022 13:40:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243986AbiBWSkd (ORCPT ); Wed, 23 Feb 2022 13:40:33 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA2454AE09 for ; Wed, 23 Feb 2022 10:40:05 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 883511F44C; Wed, 23 Feb 2022 18:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1645641604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X+EChzHy2LfrMCosgoSfL9AXBhGBFnadi6QAOtRob1E=; b=gtRhR/8czww0BMYYT26SJubp/Lrm9h0gw4vQI3C/rGHgM3VBYkRktamAPnNIDeYlPf2MUY ULjRwqrFCLUnJ0VHVPqL3offuGkwLLX/CsYyaORy2In+Nse2IiK0GfTEtzcoK0SljXFb25 +/KoNz/RlSZ+n/gsgp4ohPKMxNBV/NY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1645641604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X+EChzHy2LfrMCosgoSfL9AXBhGBFnadi6QAOtRob1E=; b=+SMNEJYtOWHMxVHc/vlOKkDuFaFbnuAgzhkRVCEvnzwueZkfiFUwl+EYBn0FBCnU5qqBFo 5Ckzk4vGBQzNIyCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5D81713C98; Wed, 23 Feb 2022 18:40:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TPEMFoR/FmKBPgAAMHmgww (envelope-from ); Wed, 23 Feb 2022 18:40:04 +0000 Message-ID: <18692a8a-00cf-67f5-e7bd-4eb82c64fdf1@suse.cz> Date: Wed, 23 Feb 2022 19:40:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 2/5] mm/sl[auo]b: Do not export __ksize() Content-Language: en-US To: Matthew Wilcox , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: linux-mm@kvack.org, Roman Gushchin , Andrew Morton , linux-kernel@vger.kernel.org, Joonsoo Kim , David Rientjes , Christoph Lameter , Pekka Enberg References: <20220221105336.522086-1-42.hyeyoo@gmail.com> <20220221105336.522086-3-42.hyeyoo@gmail.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/21/22 16:46, Matthew Wilcox wrote: > On Mon, Feb 21, 2022 at 10:53:33AM +0000, Hyeonggon Yoo wrote: >> Do not export __ksize(). Only kasan calls __ksize() directly. > > We should probably delete (most of) the kernel-doc comment on __ksize, > leaving only the note that it's uninstrumented and only called by > kasan. Also, we should probably move the declaration of __ksize from > include/linux/slab.h to mm/slab.h since we don't want to grow new callers. Agreed, thanks.