From: Mikael Pettersson <mikpe@it.uu.se>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mikael Pettersson <mikpe@it.uu.se>,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 2.6.28-rc2] i386: fix forbid_dac linkage error when CONFIG_PCI=n
Date: Mon, 27 Oct 2008 11:05:42 +0100 [thread overview]
Message-ID: <18693.37494.214451.346748@harpo.it.uu.se> (raw)
In-Reply-To: <20081027094157.GB4278@elte.hu>
Ingo Molnar writes:
>
> * Mikael Pettersson <mikpe@it.uu.se> wrote:
>
> > Fix 2.6.28-rc2 build failure on i386 with CONFIG_PCI=n:
>
> > +#ifdef CONFIG_PCI
> > if (!strncmp(p, "allowdac", 8))
> > forbid_dac = 0;
> > if (!strncmp(p, "nodac", 5))
> > @@ -210,6 +211,7 @@ static __init int iommu_setup(char *p)
> > forbid_dac = -1;
> > return 1;
> > }
> > +#endif /* CONFIG_PCI */
>
> there's a better fix for this queued up in the PCI tree, see:
>
> http://marc.info/?l=linux-kernel&m=122480590627590&w=2
Got it. Thanks.
/Mikael
prev parent reply other threads:[~2008-10-27 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 8:17 Mikael Pettersson
2008-10-27 9:41 ` Ingo Molnar
2008-10-27 10:05 ` Mikael Pettersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18693.37494.214451.346748@harpo.it.uu.se \
--to=mikpe@it.uu.se \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®