From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbdARSzw (ORCPT ); Wed, 18 Jan 2017 13:55:52 -0500 Received: from mout.web.de ([212.227.17.11]:53979 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752629AbdARSzv (ORCPT ); Wed, 18 Jan 2017 13:55:51 -0500 Subject: [PATCH 2/3] MIPS: MT: Move an assignment for the variable "retval" in mipsmt_sys_sched_setaffinity() To: linux-mips@linux-mips.org, Paul Gortmaker , =?UTF-8?Q?Ralf_B=c3=a4chle?= References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <186a1226-41df-6364-2eb9-9a2132571759@users.sourceforge.net> Date: Wed, 18 Jan 2017 19:55:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:T8M2o2HT6dqoKNkLXjIxpMo5cpg7KCPBNPR7sUDEPEiJp0DlIBg NsboSVUyUXE4Rre9IMLgBQjnERJd2rlFT9G/efWNnx2+QROytrqB6KYzTFpTIOWTayiqAt9 dETZa4b1zwr54ELQB0xz7wi8S7rUxQndqX8F+H2X3gH4HslWOU1gOtleRqgiZvLIEWOvfKL jsZecTQkAN78aVizSHnlA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZPIf5upr0fc=:KQbx64Nxya+TjSIxM7Mxvd Zkq3lcWHRcnErejM86cV14Z6VJeMFgYj0XcgKus529toEcbbKpkj4vOs4lSmc5H8XG0/OasA6 yp+MYBtBjBoBMG2ndJ1fLBdlUgn+YugLXdoPtIi9R4LEBgL4tUZsvlL0WHYMCcG1QHG4YN8Jy XuOkFOhBzqyx4xXwPWq6TNUhz3Qv5r7csL8jsWzFTAVeLuzCzmVQNgRcpGOEFa+HHPnVw6IVq jiOX+VOK2CP8GPBmxiEbxj++RKO6SV8eatjURciO2UQL2Bj4dbZZUkRreYdrZUj8wrM7SjIMh nIS1Bpt6Bbmw+k2ByXcw2WMATY5NBN9N2hcJRRFKdn48bKWAZwOsPfR4TQDmJEHvc2IOhgLgc MKmjedzzBuSSR6pnHC2Q5erJ+0azrgR4S/jVy7R2qug8xlxYuzfgqGrCwbAaQewTK+O1ZMQfH aZXVHIR9evKjvgimk1xnf/J+0sOHU+n/AmqP4RPBog6O7FlQDGzLiflXulVfjLx1A+DpsC0uO BSDqn2zm1wshwAy2aQKVJtnP3YBszX1hPPh6B4ezGvIDj6EG2odnaYLU8n7+d+8H6Da+zh0D7 BtyFScwdflrKBevGLzC3DA9Do0wS5y8I/2yPcKjRc1OPdbSUlO1xCqJSccNsmYoybkPyWv+76 2QM1EoWz0pm7OGi1PC5KiATsQ9/HZOL5uqT1Ja7tdq2GsNN8UEMN5EXln05E5QzZVicXmwRdk uaDhDRTMUdoYsShN+OnZqzvhyvk7eZG0PPYsIY+ir3C+UKwOXBfKD4NfbH0t/gSTf4aGgP70m c6p5MIg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 18 Jan 2017 19:18:37 +0100 A local variable was set to an error code in one case before a concrete error situation was detected. Thus move the corresponding assignment into an if branch to indicate a software failure there. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/mips/kernel/mips-mt-fpaff.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/mips/kernel/mips-mt-fpaff.c b/arch/mips/kernel/mips-mt-fpaff.c index 789d7bf4fef3..ddde22787287 100644 --- a/arch/mips/kernel/mips-mt-fpaff.c +++ b/arch/mips/kernel/mips-mt-fpaff.c @@ -99,9 +99,10 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len, retval = -ENOMEM; goto out_free_new_mask; } - retval = -EPERM; - if (!check_same_owner(p) && !capable(CAP_SYS_NICE)) + if (!check_same_owner(p) && !capable(CAP_SYS_NICE)) { + retval = -EPERM; goto out_unlock; + } retval = security_task_setscheduler(p); if (retval) -- 2.11.0