mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhaotianrui <zhaotianrui@loongson.cn>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Simona Vetter <simona@ffwll.ch>,
	chenhuacai@loongson.cn
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	wuqianhai@loongson.cn
Subject: Re: [PATCH] vga-switcheroo: Allow VGA_SWITCHEROO to be enabled on LoongArch
Date: Fri, 30 Oct 2026 16:39:30 +0800	[thread overview]
Message-ID: <186e26e9-da23-72e4-9464-18e9608ca8ea@loongson.cn> (raw)
In-Reply-To: <2790b59c-9b8f-43f9-a4a8-53106906bf98@suse.de>


在 2026/10/30 下午4:17, Thomas Zimmermann 写道:
> Hi
>
> Am 30.10.26 um 08:04 schrieb zhaotianrui:
>>
>> 在 2026/10/29 下午4:16, Thomas Zimmermann 写道:
>>> Hi
>>>
>>> Am 29.10.26 um 02:36 schrieb Tianrui Zhao:
>>>> LoongArch systems with hybrid graphics (integrated +
>>>> discrete GPU) can benefit from the same GPU switching
>>>> mechanism that x86 laptops use. Relax the dependency
>>>> to allow VGA_SWITCHEROO to be built on LoongArch,
>>>> consistent with the existing dependencies on ACPI,
>>>> PCI, and FB=y.
>>>>
>>>> Change-Id: I84d38fdfe5e1591495fb3681474a7f1f64281fa8
>>>
>>> Internal change ids should be remove before submitting patches.
>>>
>> Thanks for your review, I will fix this.
>>
>>
>> Best regards
>>
>> Tianrui Zhao
>>
>>>> Signed-off-by: Tianrui Zhao <zhaotianrui@loongson.cn>
>>>> ---
>>>>   drivers/gpu/vga/Kconfig | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
>>>> index bad4bcee313..89edd1211aa 100644
>>>> --- a/drivers/gpu/vga/Kconfig
>>>> +++ b/drivers/gpu/vga/Kconfig
>>>> @@ -1,7 +1,7 @@
>>>>   # SPDX-License-Identifier: GPL-2.0-only
>>>>   config VGA_SWITCHEROO
>>>>       bool "Laptop Hybrid Graphics - GPU switching support"
>>>> -    depends on X86
>>>> +    depends on X86 || LOONGARCH
>>>
>>> I'm a bit skeptical if that's all there is to do.  Does loongarch 
>>> really work with the existing handlers in the graphics drivers 
>>> as-is?  See [1] for the interface that implements the actual switching.
>>>
>>> [1] 
>>> https://elixir.bootlin.com/linux/v7.3/source/include/linux/vga_switcheroo.h#L93
>>>
>>> Best regards
>>> Thomas
>>>
>> Thanks,  I will carefully check whether all these 
>> vga_switcheroo_handler callbacks are supported on the LoongArch 
>> platform.
>
> Switcheroo used to be required for x86 notebooks from ~2010. Those 
> systems had two graphics cards, but only one set of output connectors. 
> That design is become rare, I think.
>
> So I'm a bit surprised to see it come back. Which loongarch systems 
> are there?
>
> Best regards
> Thomas
>
>
Hi Thomas,

Thanks for your reply.

On the Loongson platform, we don't have the "two GPUs but only one set 
of display outputs" scenario you described. However, we do have systems 
where an integrated GPU and a discrete GPU coexist.
We would like to use the vga_switcheroo interface to switch between the 
discrete GPU (DIS) and the integrated GPU (IGD), and to configure the 
default VGA device.
Would this approach be feasible? Do you have any suggestions or 
recommendations?

Best regards
Tianrui Zhao
>>
>>
>> Best regards
>>
>> Tianrui Zhao
>>
>>>>       depends on ACPI
>>>>       depends on PCI
>>>>       depends on FB=y
>>>
>>
>


  reply	other threads:[~2026-10-30  8:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29  1:36 Tianrui Zhao
2026-10-29  8:16 ` Thomas Zimmermann
2026-10-30  7:04   ` zhaotianrui
2026-10-30  8:17     ` Thomas Zimmermann
2026-10-30  8:39       ` zhaotianrui [this message]
2026-10-30 10:10         ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=186e26e9-da23-72e4-9464-18e9608ca8ea@loongson.cn \
    --to=zhaotianrui@loongson.cn \
    --cc=airlied@gmail.com \
    --cc=chenhuacai@loongson.cn \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=wuqianhai@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®