mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: eranian@googlemail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 00/24] perfmon3:  introduction
Date: Mon, 10 Nov 2008 13:41:32 +1100	[thread overview]
Message-ID: <18711.40796.201781.605269@drongo.ozlabs.ibm.com> (raw)
In-Reply-To: <48f8a9a3.0437560a.656a.57c5@mx.google.com>

Stephane,

I have just looked through this set of patches and it mostly looks
fine to me.  There is just one thing, and that is that the way you
access bitmaps using cast_ulp() won't work on 32-bit big-endian
machines such as 32-bit PowerPC.  I suggest that instead of using
cast_ulp(), you have a set of abstracted bit-vector operations that
can be implemented by the arch code - and on x86/ia64, they would be
implemented with cast_ulp() + test_bit/__set_bit/etc. as at present.

I hope we can get these patches into 2.6.29.

Regards,
Paul.

  parent reply	other threads:[~2008-11-10  2:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-17 15:05 eranian
2008-10-22  4:25 ` David Miller
2008-10-22  8:39   ` stephane eranian
2008-10-22 16:58     ` Jesse Barnes
2008-10-22 17:22       ` Andrew Morton
2008-10-23  7:19         ` stephane eranian
2008-11-10  2:41 ` Paul Mackerras [this message]
2008-11-10 15:24   ` stephane eranian
2008-11-11  0:29     ` stephane eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18711.40796.201781.605269@drongo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=eranian@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®