From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755017Ab2JPQRK (ORCPT ); Tue, 16 Oct 2012 12:17:10 -0400 Received: from ogre.sisk.pl ([193.178.161.156]:49445 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754371Ab2JPQRH (ORCPT ); Tue, 16 Oct 2012 12:17:07 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, patches@linaro.org, Sudeep.KarkadaNagesha@arm.com, Robin.Randhawa@arm.com, Arvind.Chauhan@arm.com Subject: Re: [PATCH] cpufreq:core: Fix printing of governor and driver name Date: Tue, 16 Oct 2012 18:20:48 +0200 Message-ID: <1873742.zv8KVPIaZX@vostro.rjw.lan> User-Agent: KMail/4.8.5 (Linux/3.6.2-6-desktop; KDE/4.8.5; x86_64; ; ) In-Reply-To: References: <51be8f865e4c80f91ac8e41e54cbd5905382ddb7.1349844049.git.viresh.kumar@linaro.org> <5507518.Gae5ZRnSWO@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 16 of October 2012 09:09:15 Viresh Kumar wrote: > On 15 October 2012 23:21, Rafael J. Wysocki wrote: > > On Wednesday 10 of October 2012 10:12:11 Viresh Kumar wrote: > >> Arrays for governer and driver name are of size CPUFREQ_NAME_LEN or 16. > >> i.e. 15 bytes for name and 1 for trailing '\0'. > >> > >> When cpufreq driver print these names (for sysfs), it includes '\n' or ' ' in > >> the fmt string and still passes length as CPUFREQ_NAME_LEN. If the driver or > >> governor names are using all 15 fields allocated to them, then the trailing '\n' > >> or ' ' will never be printed. And so commands like: > >> > >> root@linaro-developer# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_driver > >> > >> will print something like: > >> > >> cpufreq_foodrvroot@linaro-developer# > >> > >> Fix this by increasing print length by one character. > >> > >> Signed-off-by: Viresh Kumar > > > > Thanks for the patch, I'll queue it up for v3.8. > > Hi Rafael, > > Thanks for accepting the patch. > I thought both of my patches would go in 3.7-rc2 as they are bug > fixes. Isn't that correct? They don't fix serious bugs, though, so they don't look like urgent. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.