From: Paul Mackerras <paulus@samba.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nicolas Palix <npalix@diku.dk>,
benh@kernel.crashing.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Julia Lawall <julia@diku.dk>
Subject: Re: [PATCH linux-next] powerpc/powermac: Add missing of_node_put
Date: Sun, 7 Dec 2008 13:31:00 +1100 [thread overview]
Message-ID: <18747.13668.304923.709761@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20081206163449.60757c4a.akpm@linux-foundation.org>
Andrew Morton writes:
> This still misses a path - if that `return 0' is taken, we still leak
> the reference.
>
> This is reason #345 why sprinkling return statements all over your code
> is bad.
>
> I fixed it up thusly. Please check.
I'm really in two minds about applying any of the of_node_put patches
that only affect powermacs. The reference counts only matter on
platforms where we update the OF device tree at runtime, which is
currently only IBM pSeries machines. Since we don't have any hotplug
on powermacs, and never will have, the OF device tree is completely
static and we don't actually need refcounts on the nodes at all, so
who cares if they're a bit higher than they might be?
In particular, the VIA whose node we're looking for here is built-in
on the motherboard, and there can never be more than one, and it can
never be removed.
Paul.
next prev parent reply other threads:[~2008-12-07 2:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 13:45 Nicolas Palix
2008-12-02 23:19 ` Stephen Rothwell
2008-12-02 23:25 ` Stephen Rothwell
2008-12-03 10:25 ` [PATCH] " Nicolas Palix
2008-12-07 0:34 ` [PATCH linux-next] " Andrew Morton
2008-12-07 2:31 ` Paul Mackerras [this message]
2008-12-07 5:43 ` Stephen Rothwell
2008-12-07 14:09 ` Nicolas Palix
2008-12-07 23:58 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18747.13668.304923.709761@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=npalix@diku.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®