mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@it.uu.se>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Arch Mailing List <linux-arch@vger.kernel.org>
Subject: Re: Multiple math errors and SIGFPE
Date: Mon, 22 Dec 2008 23:00:28 +0100	[thread overview]
Message-ID: <18768.3580.529348.865055@harpo.it.uu.se> (raw)
In-Reply-To: <494FC03A.3090208@zytor.com>

H. Peter Anvin writes:
 > I have received a bug report related to the si_code field of siginfo for
 > SIGFPE.  The FPE_ values are (unfortunately) an enumeration rather than
 > a bitmask, so we can't just OR them together.  Unfortunately when we get
 > multiple unmasked exceptions at least on x86 we leave info.si_code to
 > __SI_FAULT, which means it is returned to userspace as zero.  This
 > violates POSIX, which states that an si_code <= 0 is a user-generated
 > signal.
 > 
 > Looking at the code in other architectures, it looks like most of them
 > prioritize the faults, but still end up with __SI_FAULT|0 if none of the
 > expected conditions are found (which may not be possible, of course.)
 > Prioritizing the faults seem like the reasonable thing to do in terms of
 >  dealing with the multiple unmasked errors problem.
 > 
 > I am wondering if it would make sense to notice the combination
 > __SI_FAULT|0 or __SI_FAULT and (short)si_code < 0 and force SI_KERNEL
 > into the user-space code field in the generic code.  I am also wondering
 > if there is any possibility that there is code out there which relies on
 > the current, buggy behaviour.

The SIGFPE handlers I've written for the Erlang VM (several CPU/OS
combinations and FPU variations where applicable) do not rely on
si_code. If they need to do autopsy they look at the fault-time FPU
status word in the ucontext.

So at least Erlang won't break if you change SIGFPE's si_code :-)

      reply	other threads:[~2008-12-22 22:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-22 16:28 H. Peter Anvin
2008-12-22 22:00 ` Mikael Pettersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18768.3580.529348.865055@harpo.it.uu.se \
    --to=mikpe@it.uu.se \
    --cc=hpa@zytor.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®