From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB627C433E9 for ; Mon, 22 Mar 2021 09:28:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F3DD61981 for ; Mon, 22 Mar 2021 09:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230142AbhCVJ2H (ORCPT ); Mon, 22 Mar 2021 05:28:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:43427 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbhCVJ1h (ORCPT ); Mon, 22 Mar 2021 05:27:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616405257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0HYs/PB5ZvBoFnReuIbosdcSKvzup9kFmar9FwoHO/k=; b=VneeffiCPQfTZRtHJKv3GOeFtw3h0hQyjF4uNoEPXzUTAE1MfYy+cXX+srQPhcQePc9YEA vv1/d90zjvL6cv7e1k0nl4WlaNPmymqWYm7KflWHIGmq3yTKHBhB6QXPPuOlCYgsSXM/NK oHDqwss4u1hGyfB9L47oMi2vq8NIQrk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-406-PE7Ae_k1N0iWzuyUF0vbaw-1; Mon, 22 Mar 2021 05:27:32 -0400 X-MC-Unique: PE7Ae_k1N0iWzuyUF0vbaw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 72AEE84E20A; Mon, 22 Mar 2021 09:27:31 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-58.rdu2.redhat.com [10.10.112.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1518F6A03C; Mon, 22 Mar 2021 09:27:26 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210320054104.1300774-4-willy@infradead.org> References: <20210320054104.1300774-4-willy@infradead.org> <20210320054104.1300774-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v5 03/27] afs: Use wait_on_page_writeback_killable MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1878263.1616405246.1@warthog.procyon.org.uk> Date: Mon, 22 Mar 2021 09:27:26 +0000 Message-ID: <1878264.1616405246@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > Open-coding this function meant it missed out on the recent bugfix > for waiters being woken by a delayed wake event from a previous > instantiation of the page. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-and-tested-by: David Howells Should this be pushed upstream now as well if it's missing out on a bugfix?