From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Kurt Borja <kuurtb@gmail.com>
Cc: W_Armin@gmx.de, Hans de Goede <hdegoede@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v8 1/4] alienware-wmi: fixed indentation and clean up
Date: Fri, 25 Oct 2024 17:11:14 +0300 (EEST) [thread overview]
Message-ID: <18792d2f-f848-eb37-87dc-b7cd5b73925b@linux.intel.com> (raw)
In-Reply-To: <20241025014016.4927-2-kuurtb@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 7488 bytes --]
On Thu, 24 Oct 2024, Kurt Borja wrote:
> Fixed inconsistent indentation and removed unnecessary (acpi_size) and
> (u32 *) casts.
>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
> ---
> v8:
> - Unchanged
> v7:
> - Unchanged
> v6:
> - Unchanged
> ---
> drivers/platform/x86/dell/alienware-wmi.c | 134 +++++++++++-----------
> 1 file changed, 67 insertions(+), 67 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c
> index f5ee62ce1..16a3fe9ac 100644
> --- a/drivers/platform/x86/dell/alienware-wmi.c
> +++ b/drivers/platform/x86/dell/alienware-wmi.c
> @@ -116,68 +116,68 @@ static int __init dmi_matched(const struct dmi_system_id *dmi)
>
> static const struct dmi_system_id alienware_quirks[] __initconst = {
> {
> - .callback = dmi_matched,
> - .ident = "Alienware X51 R3",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "Alienware X51 R3"),
> - },
> - .driver_data = &quirk_x51_r3,
> - },
> + .callback = dmi_matched,
> + .ident = "Alienware X51 R3",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Alienware X51 R3"),
> + },
> + .driver_data = &quirk_x51_r3,
> + },
> {
> - .callback = dmi_matched,
> - .ident = "Alienware X51 R2",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "Alienware X51 R2"),
> - },
> - .driver_data = &quirk_x51_r1_r2,
> - },
> + .callback = dmi_matched,
> + .ident = "Alienware X51 R2",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Alienware X51 R2"),
> + },
> + .driver_data = &quirk_x51_r1_r2,
> + },
> {
> - .callback = dmi_matched,
> - .ident = "Alienware X51 R1",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "Alienware X51"),
> - },
> - .driver_data = &quirk_x51_r1_r2,
> - },
> + .callback = dmi_matched,
> + .ident = "Alienware X51 R1",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Alienware X51"),
> + },
> + .driver_data = &quirk_x51_r1_r2,
> + },
> {
> - .callback = dmi_matched,
> - .ident = "Alienware ASM100",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "ASM100"),
> - },
> - .driver_data = &quirk_asm100,
> - },
> + .callback = dmi_matched,
> + .ident = "Alienware ASM100",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "ASM100"),
> + },
> + .driver_data = &quirk_asm100,
> + },
> {
> - .callback = dmi_matched,
> - .ident = "Alienware ASM200",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "ASM200"),
> - },
> - .driver_data = &quirk_asm200,
> - },
> + .callback = dmi_matched,
> + .ident = "Alienware ASM200",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "ASM200"),
> + },
> + .driver_data = &quirk_asm200,
> + },
> {
> - .callback = dmi_matched,
> - .ident = "Alienware ASM201",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "ASM201"),
> - },
> - .driver_data = &quirk_asm201,
> - },
> - {
> - .callback = dmi_matched,
> - .ident = "Dell Inc. Inspiron 5675",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5675"),
> - },
> - .driver_data = &quirk_inspiron5675,
> - },
> + .callback = dmi_matched,
> + .ident = "Alienware ASM201",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "ASM201"),
> + },
> + .driver_data = &quirk_asm201,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "Dell Inc. Inspiron 5675",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5675"),
> + },
> + .driver_data = &quirk_inspiron5675,
> + },
> {}
> };
>
> @@ -221,8 +221,8 @@ static struct platform_zone *zone_data;
>
> static struct platform_driver platform_driver = {
> .driver = {
> - .name = "alienware-wmi",
> - }
> + .name = "alienware-wmi",
> + }
> };
>
> static struct attribute_group zone_attribute_group = {
> @@ -292,7 +292,7 @@ static int alienware_update_led(struct platform_zone *zone)
> guid = WMAX_CONTROL_GUID;
> method_id = WMAX_METHOD_ZONE_CONTROL;
>
> - input.length = (acpi_size) sizeof(wmax_basic_args);
> + input.length = sizeof(wmax_basic_args);
> input.pointer = &wmax_basic_args;
> } else {
> legacy_args.colors = zone->colors;
> @@ -306,7 +306,7 @@ static int alienware_update_led(struct platform_zone *zone)
> guid = LEGACY_CONTROL_GUID;
> method_id = zone->location + 1;
>
> - input.length = (acpi_size) sizeof(legacy_args);
> + input.length = sizeof(legacy_args);
> input.pointer = &legacy_args;
> }
> pr_debug("alienware-wmi: guid %s method %d\n", guid, method_id);
> @@ -358,7 +358,7 @@ static int wmax_brightness(int brightness)
> .led_mask = 0xFF,
> .percentage = brightness,
> };
> - input.length = (acpi_size) sizeof(args);
> + input.length = sizeof(args);
> input.pointer = &args;
> status = wmi_evaluate_method(WMAX_CONTROL_GUID, 0,
> WMAX_METHOD_BRIGHTNESS, &input, NULL);
> @@ -508,7 +508,7 @@ static acpi_status alienware_wmax_command(struct wmax_basic_args *in_args,
> struct acpi_buffer input;
> struct acpi_buffer output;
>
> - input.length = (acpi_size) sizeof(*in_args);
> + input.length = sizeof(*in_args);
> input.pointer = in_args;
> if (out_data) {
> output.length = ACPI_ALLOCATE_BUFFER;
> @@ -542,7 +542,7 @@ static ssize_t show_hdmi_cable(struct device *dev,
> };
> status =
> alienware_wmax_command(&in_args, WMAX_METHOD_HDMI_CABLE,
> - (u32 *) &out_data);
> + &out_data);
> if (ACPI_SUCCESS(status)) {
> if (out_data == 0)
> return sysfs_emit(buf, "[unconnected] connected unknown\n");
> @@ -563,7 +563,7 @@ static ssize_t show_hdmi_source(struct device *dev,
> };
> status =
> alienware_wmax_command(&in_args, WMAX_METHOD_HDMI_STATUS,
> - (u32 *) &out_data);
> + &out_data);
>
> if (ACPI_SUCCESS(status)) {
> if (out_data == 1)
> @@ -643,7 +643,7 @@ static ssize_t show_amplifier_status(struct device *dev,
> };
> status =
> alienware_wmax_command(&in_args, WMAX_METHOD_AMPLIFIER_CABLE,
> - (u32 *) &out_data);
> + &out_data);
> if (ACPI_SUCCESS(status)) {
> if (out_data == 0)
> return sysfs_emit(buf, "[unconnected] connected unknown\n");
> @@ -695,7 +695,7 @@ static ssize_t show_deepsleep_status(struct device *dev,
> .arg = 0,
> };
> status = alienware_wmax_command(&in_args, WMAX_METHOD_DEEP_SLEEP_STATUS,
> - (u32 *) &out_data);
> + &out_data);
> if (ACPI_SUCCESS(status)) {
> if (out_data == 0)
> return sysfs_emit(buf, "[disabled] s5 s5_s4\n");
>
next prev parent reply other threads:[~2024-10-25 14:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 1:38 [PATCH v8 0/4] Dell AWCC platform_profile support Kurt Borja
2024-10-25 1:40 ` [PATCH v8 1/4] alienware-wmi: fixed indentation and clean up Kurt Borja
2024-10-25 14:11 ` Ilpo Järvinen [this message]
2024-10-25 1:41 ` [PATCH v8 2/4] alienware-wmi: alienware_wmax_command() is now input size agnostic Kurt Borja
2024-10-25 14:12 ` Ilpo Järvinen
2024-10-25 1:41 ` [PATCH v8 3/4] alienware-wmi: added platform profile support Kurt Borja
2024-10-25 14:09 ` Ilpo Järvinen
2024-10-25 14:29 ` Kurt Borja
2024-10-25 1:42 ` [PATCH v8 4/4] alienware-wmi: WMAX interface documentation Kurt Borja
2024-10-25 14:13 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18792d2f-f848-eb37-87dc-b7cd5b73925b@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=W_Armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®