From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m155106.qiye.163.com (mail-m155106.qiye.163.com [101.71.155.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E6A122B8CB; Sun, 4 Jan 2026 02:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767495098; cv=none; b=fo0WNjir1TRywWOM7DLyXS95sf2ImSya8TVSlI0yB4ypVam3qWEV9ToGDvA8jf8uPViS7llTQhhyWzUz55OubKqbMzqib5AlE7q0fZefDK0gkWmFFASXjgC7USisgJyd44DArMzb2bKcK7XCnUICPziDctl3o8b2Uq+oZyKxmEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767495098; c=relaxed/simple; bh=G9NZDnOPZuICA+JmhJRwlj4wa5JZogXr97XY8R5BBcM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EphXUJCh4d2jfmMisjN8EEDkmrhtqDccIlzOl1Gue2vF2oIkqOUAyyzjK0UXlW5b8YHAUca9RNtS9DycNf6Kt/xQFlZiMic8AfV68rTW0efMpX3rZryOJdbSBV2MWRuHRLpo63nJYId9GZfapyjRatrQWYhwYAreG0+ok53rgZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=VN9D4w7t; arc=none smtp.client-ip=101.71.155.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="VN9D4w7t" Received: from [172.16.12.43] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 2f64a21bd; Sun, 4 Jan 2026 10:51:21 +0800 (GMT+08:00) Message-ID: <187b2c32-5a10-4555-8d49-cf1ee86a8eaa@rock-chips.com> Date: Sun, 4 Jan 2026 10:51:20 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 04/18] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge To: Luca Ceresoli , andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, alim.akhtar@samsung.com, jingoohan1@gmail.com, p.zabel@pengutronix.de, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com, dianders@chromium.org, m.szyprowski@samsung.com, jani.nikula@intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20251217093321.3108939-1-damon.ding@rock-chips.com> <20251217093321.3108939-5-damon.ding@rock-chips.com> Content-Language: en-US From: Damon Ding In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9b86ea9d6203a3kunm609d12354f1e56 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGkwdT1ZMHk4dTUpJH0JDSkhWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=VN9D4w7tVJY1+ljTAsa1MLD6Mu0695ntJQk+KIoXGFCQLS3AiPDzWBuYLRrFP0sAOg9safZng8mqTRky7UnUhtfUSarzUuLouyURZ1nj5GNN756VDJNoBoz0VnDjQWRid6XqjAc5x1XIGQu2r4+UGXppXY0p2CdNt9zvZDLGVvQ=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=ZqFoCcwJQuU5a4YfLtrUVBGWJRctrtxu3bkHphWi05w=; h=date:mime-version:subject:message-id:from; Hi Luca, On 12/31/2025 7:11 PM, Luca Ceresoli wrote: > Hello Damon, > > On Wed Dec 17, 2025 at 10:33 AM CET, Damon Ding wrote: >> In order to move the panel/bridge parsing and attachmenet to the >> Analogix side, add component struct drm_bridge *next_bridge to >> platform data struct analogix_dp_plat_data. >> >> The movement makes sense because the panel/bridge should logically >> be positioned behind the Analogix bridge in the display pipeline. >> >> Signed-off-by: Damon Ding >> Reviewed-by: Dmitry Baryshkov >> Tested-by: Marek Szyprowski >> >> --- >> >> Changes in v4: >> - Rename the &analogix_dp_plat_data.bridge to >> &analogix_dp_plat_data.next_bridge >> --- >> include/drm/bridge/analogix_dp.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/drm/bridge/analogix_dp.h b/include/drm/bridge/analogix_dp.h >> index cf17646c1310..582357c20640 100644 >> --- a/include/drm/bridge/analogix_dp.h >> +++ b/include/drm/bridge/analogix_dp.h >> @@ -27,6 +27,7 @@ static inline bool is_rockchip(enum analogix_dp_devtype type) >> struct analogix_dp_plat_data { >> enum analogix_dp_devtype dev_type; >> struct drm_panel *panel; >> + struct drm_bridge *next_bridge; >> struct drm_encoder *encoder; >> struct drm_connector *connector; >> bool skip_connector; > > It took a while to understand why you are adding the next_bridge pointer in > struct analogix_dp_plat_data instead of struct analogix_dp_device, where it > would be more natural. I found an answer in patch 16: with current code you > need to place next_bridge in struct analogix_dp_plat_data because it is > used by user drivers to attach, and those drivers have no access to struct > analogix_dp_device. However patch 16 (which looks a very good cleanup BTW) > next_bridge can be moved to struct analogix_dp_device. > > So I'd suggest to move patch 16 before this one if it easily doable, so > that you can introduce next_bridge in struct analogix_dp_device from the > beginning. Should that be impossible, you can send a separate patch to move > next_bridge, after patch 16. > > Thanks for your nice suggestion! After patch 16, bridge attachment is unified to the Analogix side, which acts as a common bridge driver for both the Rockchip and Exynos sides, so moving next_bridge there makes perfect sense. I will add a separate patch to move next_bridge in v9. Best regards, Damon