From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbbCYLQG (ORCPT ); Wed, 25 Mar 2015 07:16:06 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:49215 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752398AbbCYLQD (ORCPT ); Wed, 25 Mar 2015 07:16:03 -0400 From: "Rafael J. Wysocki" To: Javi Merino Cc: akpm@linux-foundation.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, emil.l.velikov@gmail.com, jepler@unpythonic.net, daniel@ffwll.ch, "Rafael J. Wysocki" , Mel Gorman , Stephen Hemminger Subject: Re: [PATCH v2 3/4] cpuidle: menu: use DIV_ROUND_CLOSEST_ULL() Date: Wed, 25 Mar 2015 12:40:05 +0100 Message-ID: <18811399.xu7uosvK4d@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.19.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1427205825-5444-4-git-send-email-javi.merino@arm.com> References: <1427205825-5444-1-git-send-email-javi.merino@arm.com> <1427205825-5444-4-git-send-email-javi.merino@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, March 24, 2015 02:03:44 PM Javi Merino wrote: > Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal > implementation and use the kernel one. > > Cc: "Rafael J. Wysocki" > Cc: Mel Gorman > Cc: Stephen Hemminger > Signed-off-by: Javi Merino Acked-by: Rafael J. Wysocki > --- > drivers/cpuidle/governors/menu.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c > index 40580794e23d..b8a5fa15ca24 100644 > --- a/drivers/cpuidle/governors/menu.c > +++ b/drivers/cpuidle/governors/menu.c > @@ -190,12 +190,6 @@ static DEFINE_PER_CPU(struct menu_device, menu_devices); > > static void menu_update(struct cpuidle_driver *drv, struct cpuidle_device *dev); > > -/* This implements DIV_ROUND_CLOSEST but avoids 64 bit division */ > -static u64 div_round64(u64 dividend, u32 divisor) > -{ > - return div_u64(dividend + (divisor / 2), divisor); > -} > - > /* > * Try detecting repeating patterns by keeping track of the last 8 > * intervals, and checking if the standard deviation of that set > @@ -317,7 +311,7 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) > * operands are 32 bits. > * Make sure to round up for half microseconds. > */ > - data->predicted_us = div_round64((uint64_t)data->next_timer_us * > + data->predicted_us = DIV_ROUND_CLOSEST_ULL((uint64_t)data->next_timer_us * > data->correction_factor[data->bucket], > RESOLUTION * DECAY); > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.