mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf_counter: Prevent oopses from per-cpu software counters
Date: Fri, 6 Feb 2009 13:40:34 +1100	[thread overview]
Message-ID: <18827.41762.860654.259240@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20090205142229.GB28443@elte.hu>

Ingo Molnar writes:

> You are right that "pagefaults" and "context switches" do get generated by 
> tasks - but there is a per cpu and system wide notion of 'number of 
> pagefaults', and people might be interested in monitoring that.

Sure.  What I was trying to say was that the existing code for the
page fault, context switch and task migration software counters uses
"current", so as it is, they can't be used as per-cpu counters.

> The existence and widespread use of "vmstat", and its display of system-wide 
> count of "context switches" (and administrator's reliance on judging a 
> workload based on those counts) is i think ample proof that it makes sense 
> to have those counters on a per CPU basis too.
> 
> So how about fixing these sw counts to properly work as percpu counters too? 
> Or am i misssing something subtle that makes that impossible?

I'll do that, but I think it can be a second patch on top of the one I
posted.  My existing patch doesn't disable anything that previously
worked, it just stops you doing things that would cause an oops.  So I
think it is strictly an improvement on the current situation.

Paul.

  reply	other threads:[~2009-02-06  2:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05  4:52 Paul Mackerras
2009-02-05 14:22 ` Ingo Molnar
2009-02-06  2:40   ` Paul Mackerras [this message]
2009-02-06  4:34   ` Paul Mackerras
2009-02-06  6:35     ` Zhang, Yanmin
2009-02-06 15:31     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18827.41762.860654.259240@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®