From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Depeng Shao <quic_depengs@quicinc.com>,
rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org,
konrad.dybcio@linaro.org, mchehab@kernel.org,
quic_yon@quicinc.com
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 6/8] media: qcom: camss: Add new VFE driver for SM8550
Date: Tue, 9 Apr 2024 14:39:34 +0100 [thread overview]
Message-ID: <18837b02-27af-4d0c-a772-bb7ce787a4c0@linaro.org> (raw)
In-Reply-To: <20240320141136.26827-7-quic_depengs@quicinc.com>
On 20/03/2024 14:11, Depeng Shao wrote:
> +#define VFE_IRQ_STATUS(n) ((vfe_is_lite(vfe) ? 0x101C : 0x44) + (n) * 4)
These defines do the right thing for the RDI however
1. Please use 'rdi' not 'n' as the parameter here and
2. Pass 'vfe' explicitly not implicitly
Right now you need a variable named 'vfe' in the scope of the macro but
that ought to be an explicit parameter passed to the macro.
---
bod
next prev parent reply other threads:[~2024-04-09 13:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 14:11 [PATCH v2 0/8] media: qcom: camss: Add sm8550 support Depeng Shao
2024-03-20 14:11 ` [PATCH v2 1/8] media: qcom: camss: Add CAMSS_8550 enum Depeng Shao
2024-03-20 14:50 ` Bryan O'Donoghue
2024-03-20 15:51 ` Krzysztof Kozlowski
2024-03-20 15:53 ` Bryan O'Donoghue
2024-03-20 15:59 ` Krzysztof Kozlowski
2024-03-20 14:11 ` [PATCH v2 2/8] media: qcom: camss: Add subdev notify support Depeng Shao
2024-03-20 16:08 ` Bryan O'Donoghue
2024-03-20 16:41 ` Gjorgji Rosikopulos (Consultant)
2024-03-20 14:11 ` [PATCH v2 3/8] media: qcom: camss: Add new csiphy driver 2-1-2 Depeng Shao
2024-03-20 15:21 ` Bryan O'Donoghue
2024-03-25 12:15 ` Depeng Shao
2024-03-20 14:11 ` [PATCH v2 4/8] media: qcom: camss: Add new params for csid_device Depeng Shao
2024-03-20 15:26 ` Bryan O'Donoghue
2024-03-20 15:53 ` Krzysztof Kozlowski
2024-03-25 12:30 ` Depeng Shao
2024-03-20 14:11 ` [PATCH v2 5/8] media: qcom: camss: Add CSID gen3 driver Depeng Shao
2024-03-20 15:40 ` Bryan O'Donoghue
2024-03-20 16:12 ` Bryan O'Donoghue
2024-03-25 13:38 ` Depeng Shao
2024-03-20 14:11 ` [PATCH v2 6/8] media: qcom: camss: Add new VFE driver for SM8550 Depeng Shao
2024-03-20 15:57 ` Bryan O'Donoghue
2024-03-25 12:47 ` Depeng Shao
2024-04-09 13:39 ` Bryan O'Donoghue [this message]
2024-04-09 15:35 ` Bryan O'Donoghue
2024-03-20 14:11 ` [PATCH v2 7/8] media: qcom: camss: Add sm8550 resources Depeng Shao
2024-03-20 15:50 ` Krzysztof Kozlowski
2024-03-20 14:11 ` [PATCH v2 8/8] media: qcom: camss: Add sm8550 support Depeng Shao
2024-03-20 16:01 ` Bryan O'Donoghue
2024-03-25 13:16 ` Depeng Shao
2024-03-20 15:08 ` [PATCH v2 0/8] " Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18837b02-27af-4d0c-a772-bb7ce787a4c0@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_depengs@quicinc.com \
--cc=quic_yon@quicinc.com \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®