Re: [PATCH/RFC 1/2] perfcounters: provide a way to read the current value of interrupting counters

[Paul Mackerras <paulus@samba.org>]

Peter Zijlstra writes:

> I'm not sure I understand why. It seems to me you're either interested
> in sample data, that is {tid,ip,counter} like things, or you want raw
> count values.

It was specifically requested by people porting PAPI to PCL, and it
seems like a reasonable request.

> This seems unrelated, what will stop us now from adding record_type
> values? PERF_RECORD_CALLCHAIN is one in particular I'd like to add soon.

I think we should make record_type a bitset rather than a single
value, and define bits for recording the callchain as well as various
other interesting things.

> This is a bit bothersome, as we then have no unique identifier anymore.
> 
> Currently the group record type writes things like {hw_event->type,
> counter} which is ambiguous since we really have a 65bit id space. So I
> was thinking of making that {fd, counter} to at least have a unique
> identifier in there.

The fd is already not a unique identifier - think about dup().

The hw_event->type values are not really necessary, in fact, since the
group members will always be read out in the order that they were
added to the group.  The only time there might be any possibility of
confusion is if a new member is added after some samples have already
been taken (or a member is removed) - then we'll get new records being
added to the event queue being a different size from those already in
the queue.  But that's a somewhat different problem which isn't really
solved by having the type values in there.

Paul.