From: Vignesh Raghavendra <vigneshr@ti.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
"Ronald G. Minnich" <rminnich@gmail.com>
Cc: "Ronald G. Minnich" <rminnich@google.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Boris Brezillon <bbrezillon@kernel.org>,
Jethro Beekman <jethro@fortanix.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Thomas Gleixner <tglx@linutronix.de>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: controllers: intel-spi: Add support for command line partitions
Date: Fri, 25 Sep 2020 09:51:14 +0530 [thread overview]
Message-ID: <1887c783-7a80-a71c-949f-c07c83c2d0fe@ti.com> (raw)
In-Reply-To: <20200417160736.GE2586@lahna.fi.intel.com>
On 4/17/20 9:37 PM, Mika Westerberg wrote:
> On Fri, Apr 17, 2020 at 08:26:11AM -0700, Ronald G. Minnich wrote:
>> On Intel platforms, the usable SPI area is located several
>> MiB in from the start, to leave room for descriptors and
>> the Management Engine binary. Further, not all the remaining
>> space can be used, as the last 16 MiB contains firmware.
>>
>> To make the SPI usable for mtdblock and other devices,
>> it is necessary to enable command line partitions so the
>> middle usable region can be specified.
>>
>> Add a part_probes array which includes only "cmdelineparts",
>> and change to mtd_device_parse_register to use this part_probes.
>>
>> Signed-off-by: Ronald G. Minnich <rminnich@google.com>
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
scripts/checkpatch.pl --strict complains:
CHECK: Alignment should match open parenthesis
#46: FILE: drivers/mtd/spi-nor/controllers/intel-spi.c:956:
+ ret = mtd_device_parse_register(&ispi->nor.mtd, part_probes,
+ NULL, &part, 1);
WARNING: Missing Signed-off-by: line by nominal patch author '"Ronald G. Minnich" <rminnich@gmail.com>'
Regards
Vignesh
next prev parent reply other threads:[~2020-09-25 4:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 15:26 Ronald G. Minnich
2020-04-17 16:07 ` Mika Westerberg
2020-09-25 4:21 ` Vignesh Raghavendra [this message]
2020-12-23 21:56 ` [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons Ian Goegebuer
2021-01-04 9:08 ` Miquel Raynal
2021-01-04 16:24 ` Ron Minnich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1887c783-7a80-a71c-949f-c07c83c2d0fe@ti.com \
--to=vigneshr@ti.com \
--cc=alexander.sverdlin@nokia.com \
--cc=bbrezillon@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jethro@fortanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=rminnich@gmail.com \
--cc=rminnich@google.com \
--cc=tglx@linutronix.de \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®