From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbdBULqL (ORCPT ); Tue, 21 Feb 2017 06:46:11 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:35580 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbdBULqF (ORCPT ); Tue, 21 Feb 2017 06:46:05 -0500 Subject: Re: [PATCH] KVM: VMX: use correct vmcs_read/write for guest segment selector/base To: Chao Peng , kvm@vger.kernel.org References: <1487667001-37219-1-git-send-email-chao.p.peng@linux.intel.com> Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org From: Paolo Bonzini Message-ID: <188e359e-44f2-1f7e-474c-96698986a0f5@redhat.com> Date: Tue, 21 Feb 2017 12:46:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1487667001-37219-1-git-send-email-chao.p.peng@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/02/2017 09:50, Chao Peng wrote: > Guest segment selector is 16 bit field and guest segment base is natural > width field. Fix two incorrect invocations accordingly. > > Without this patch, build fails when aggressive inlining is used with ICC. > > Cc: stable@vger.kernel.org > Signed-off-by: Chao Peng Applied, thanks. Paolo > --- > arch/x86/kvm/vmx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index a236dec..2c22aef 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -3962,7 +3962,7 @@ static void fix_rmode_seg(int seg, struct kvm_segment *save) > } > > vmcs_write16(sf->selector, var.selector); > - vmcs_write32(sf->base, var.base); > + vmcs_writel(sf->base, var.base); > vmcs_write32(sf->limit, var.limit); > vmcs_write32(sf->ar_bytes, vmx_segment_access_rights(&var)); > } > @@ -8350,7 +8350,7 @@ static void kvm_flush_pml_buffers(struct kvm *kvm) > static void vmx_dump_sel(char *name, uint32_t sel) > { > pr_err("%s sel=0x%04x, attr=0x%05x, limit=0x%08x, base=0x%016lx\n", > - name, vmcs_read32(sel), > + name, vmcs_read16(sel), > vmcs_read32(sel + GUEST_ES_AR_BYTES - GUEST_ES_SELECTOR), > vmcs_read32(sel + GUEST_ES_LIMIT - GUEST_ES_SELECTOR), > vmcs_readl(sel + GUEST_ES_BASE - GUEST_ES_SELECTOR)); >