From: Keoseong Park <keosung.park@samsung.com>
To: ALIM AKHTAR <alim.akhtar@samsung.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
Kiwoong Kim <kwmad.kim@samsung.com>,
"satyat@google.com" <satyat@google.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jpinto@synopsys.com" <jpinto@synopsys.com>,
"joe@perches.com" <joe@perches.com>
Subject: [PATCH v2] scsi: ufs: Refactor ufshcd_is_intr_aggr_allowed()
Date: Mon, 28 Jun 2021 14:58:01 +0900 [thread overview]
Message-ID: <1891546521.01624860001810.JavaMail.epsvc@epcpadp3> (raw)
In-Reply-To: <CGME20210628055801epcms2p449fdffa1a6c801497d7e65bae2896b79@epcms2p4>
Simplify if else statement to return statement,
and remove code related to CONFIG_SCSI_UFS_DWC that is not in use.
v1 -> v2
Remove code related to CONFIG_SCSI_UFS_DWC that is not in use.
Cc: Joao Pinto <jpinto@synopsys.com>
Signed-off-by: Keoseong Park <keosung.park@samsung.com>
---
drivers/scsi/ufs/ufshcd.h | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index c98d540ac044..c9faca237290 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -893,16 +893,8 @@ static inline bool ufshcd_is_rpm_autosuspend_allowed(struct ufs_hba *hba)
static inline bool ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba)
{
-/* DWC UFS Core has the Interrupt aggregation feature but is not detectable*/
-#ifndef CONFIG_SCSI_UFS_DWC
- if ((hba->caps & UFSHCD_CAP_INTR_AGGR) &&
- !(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR))
- return true;
- else
- return false;
-#else
-return true;
-#endif
+ return (hba->caps & UFSHCD_CAP_INTR_AGGR) &&
+ !(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR);
}
static inline bool ufshcd_can_aggressive_pc(struct ufs_hba *hba)
--
2.17.1
next parent reply other threads:[~2021-06-28 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210628055801epcms2p449fdffa1a6c801497d7e65bae2896b79@epcms2p4>
2021-06-28 5:58 ` Keoseong Park [this message]
2021-06-28 6:32 ` Bean Huo
2021-06-28 16:56 ` Bart Van Assche
2021-07-18 21:52 ` Martin K. Petersen
2021-07-24 2:13 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1891546521.01624860001810.JavaMail.epsvc@epcpadp3 \
--to=keosung.park@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=joe@perches.com \
--cc=jpinto@synopsys.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=satyat@google.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®