mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Won Jung <wone.jung@samsung.com>
To: ALIM AKHTAR <alim.akhtar@samsung.com>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"peter.wang@mediatek.com" <peter.wang@mediatek.com>,
	"beanhuo@micron.com" <beanhuo@micron.com>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jinyoung Choi <j-young.choi@samsung.com>,
	Jeuk Kim <jeuk20.kim@samsung.com>
Subject: [PATCH] scsi: ufs: core: Reset urgent_bkops_lvl to allow runtime PM power mode
Date: Wed, 11 Feb 2026 15:01:05 +0900	[thread overview]
Message-ID: <1891546521.01770806581968.JavaMail.epsvc@epcpadp2new> (raw)
In-Reply-To: <CGME20260211060105epcms2p6631646c964afae761c5d8b93db5a476d@epcms2p6>

This patch ensures that UFS Runtime PM can achieve power saving
after System PM suspend by resetting hba->urgent_bkops_lvl.
It also modifies ufshcd_bkops_exception_event_handler to avoid
setting urgent_bkops_lvl when status is 0, which helps maintain
optimal power management.

On UFS devices supporting UFSHCD_CAP_AUTO_BKOPS_SUSPEND,
a BKOPS exception event can lead to a situation
where UFS Runtime PM can't enter low-power mode states even
after the BKOPS exception has been resolved.

BKOPS exception with bkops status 0 occurs, the driver logs:
"ufshcd_bkops_exception_event_handler:
device raised urgent BKOPS exception for bkops status 0"

When a BKOPS exception occurs, `ufshcd_bkops_exception_event_handler()`
reads the BKOPS status and sets `hba->urgent_bkops_lvl` to
BKOPS_STATUS_NO_OP(0). This allows the device to perform Runtime PM
without changing the UFS power mode.
(`__ufshcd_wl_suspend(hba, UFS_RUNTIME_PM)`)

During system PM suspend, `ufshcd_disable_auto_bkops()` is called,
disabling auto bkops. After UFS System PM Resume,
when runtime PM attempts to suspend again,
`ufshcd_urgent_bkops()` is invoked. Since `hba->urgent_bkops_lvl`
remains at BKOPS_STATUS_NO_OP(0), `ufshcd_enable_auto_bkops()`
is triggered.

However, in `ufshcd_bkops_ctrl()`,
the driver compares the current BKOPS status with
`hba->urgent_bkops_lvl`, and only enables auto bkops
if `curr_status >= hba->urgent_bkops_lvl`.
Since both values are 0, the condition is met

As a result, `__ufshcd_wl_suspend(hba, UFS_RUNTIME_PM)` skips power mode
transitions and remains in an active state, preventing power saving even
though no urgent BKOPS condition exists.

Signed-off-by: wone.jung <wone.jung@samsung.com>
---
 drivers/ufs/core/ufshcd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 604043a7533d..e2d3e834ccba 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -5959,6 +5959,7 @@ static int ufshcd_disable_auto_bkops(struct ufs_hba *hba)
 
 	hba->auto_bkops_enabled = false;
 	trace_ufshcd_auto_bkops_state(hba, "Disabled");
+	hba->urgent_bkops_lvl = BKOPS_STATUS_PERF_IMPACT;
 	hba->is_urgent_bkops_lvl_checked = false;
 out:
 	return err;
@@ -6062,7 +6063,7 @@ static void ufshcd_bkops_exception_event_handler(struct ufs_hba *hba)
 	 * impacted or critical. Handle these device by determining their urgent
 	 * bkops status at runtime.
 	 */
-	if (curr_status < BKOPS_STATUS_PERF_IMPACT) {
+	if ((curr_status > BKOPS_STATUS_NO_OP) && (curr_status < BKOPS_STATUS_PERF_IMPACT)) {
 		dev_err(hba->dev, "%s: device raised urgent BKOPS exception for bkops status %d\n",
 				__func__, curr_status);
 		/* update the current status as the urgent bkops level */
-- 
2.17.1

       reply	other threads:[~2026-02-11 10:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260211060105epcms2p6631646c964afae761c5d8b93db5a476d@epcms2p6>
2026-02-11  6:01 ` Won Jung [this message]
2026-02-11 13:00   ` Peter Wang (王信友)
2026-02-18  2:30   ` Martin K. Petersen
2026-02-24 16:47   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1891546521.01770806581968.JavaMail.epsvc@epcpadp2new \
    --to=wone.jung@samsung.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=j-young.choi@samsung.com \
    --cc=jeuk20.kim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.wang@mediatek.com \
    --cc=quic_nguyenb@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome