From: Paul Mackerras <paulus@samba.org>
To: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/5] perf_counter: rework ioctl()s
Date: Tue, 12 May 2009 06:52:30 +1000 [thread overview]
Message-ID: <18952.36878.942836.803265@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <4A086A89.6030905@linux.vnet.ibm.com>
Corey Ashford writes:
> One problem that I was seeing was that disabling only the group leader didn't
> keep the group member hardware counters from continuing to run and generate
> overflows, and causing sample records to be put in the mmap buffer.
That's very strange. Disabling the group leader should have taken the
whole group off the PMU and so none of the members should have been
able to generate any more overflows or sample records. What machines
did you see this on?
> Was this the intention?
Not at all.
> For PAPI, we really need to be able to disable, at least, the sample records
> from going into the mmap buffers. Even better would be to stop the hardware
> counters from counting while disabled.
Disabling the leader should be doing all that.
Paul.
next prev parent reply other threads:[~2009-05-11 20:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 16:52 [PATCH 0/5] pending patches Peter Zijlstra
2009-05-08 16:52 ` [PATCH 1/5] hrtimer: per-cpu cached values of ktime Peter Zijlstra
2009-05-08 23:10 ` Andrew Morton
2009-05-09 19:45 ` Linus Torvalds
2009-05-09 19:59 ` Peter Zijlstra
2009-05-08 16:52 ` [PATCH 2/5] perf_counter: optimize perf_counter_task_tick() Peter Zijlstra
2009-05-08 18:39 ` [tip:perfcounters/core] " tip-bot for Peter Zijlstra
2009-05-08 16:52 ` [PATCH 3/5] perf_counter: rework ioctl()s Peter Zijlstra
2009-05-08 18:39 ` [tip:perfcounters/core] " tip-bot for Peter Zijlstra
2009-05-11 1:29 ` [PATCH 3/5] " Paul Mackerras
2009-05-11 15:12 ` Peter Zijlstra
2009-05-12 6:24 ` Paul Mackerras
2009-05-11 18:12 ` Corey Ashford
2009-05-11 20:52 ` Paul Mackerras [this message]
2009-05-11 22:37 ` Corey Ashford
2009-05-12 6:16 ` Paul Mackerras
2009-05-12 16:15 ` Corey Ashford
2009-05-12 22:18 ` Paul Mackerras
2009-05-12 22:51 ` Corey Ashford
2009-05-11 23:58 ` Arnd Bergmann
2009-05-12 6:11 ` Peter Zijlstra
2009-05-12 6:22 ` Paul Mackerras
2009-05-12 6:27 ` Peter Zijlstra
2009-05-12 7:10 ` Peter Zijlstra
2009-05-12 7:52 ` Arnd Bergmann
2009-05-12 10:59 ` [PATCH] perf_counter: fix ioctl()s Peter Zijlstra
2009-05-12 11:21 ` [PATCH 3/5] perf_counter: rework ioctl()s Paul Mackerras
2009-05-08 16:52 ` [PATCH 4/5] perf_counter: PERF_RECORD_CONFIG Peter Zijlstra
2009-05-08 18:39 ` [tip:perfcounters/core] perf_counter: add PERF_RECORD_CONFIG tip-bot for Peter Zijlstra
2009-05-08 16:52 ` [PATCH 5/5] perf_counter: PERF_RECORD_CPU Peter Zijlstra
2009-05-08 18:40 ` [tip:perfcounters/core] perf_counter: add PERF_RECORD_CPU tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18952.36878.942836.803265@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®