mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Yinghai Lu <yinghai@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Aaron Lu <aaron.lu@intel.com>, Tejun Heo <tj@kernel.org>,
	linux-ide@vger.kernel.org
Subject: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names
Date: Sat, 27 Jul 2013 15:11:27 +0200	[thread overview]
Message-ID: <1895563.95T8SxMegu@vostro.rjw.lan> (raw)
In-Reply-To: <10433383.dueoNg39qi@vostro.rjw.lan>

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Modify acpi_device_set_power() so that diagnostic messages printed by
it to the kernel log always contain the name of the device concerned
to make it possible to identify the device that triggered the message
if need be.

Also replace printk(KERN_WARNING ) with dev_warn() everywhere in that
function.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/device_pm.c |   22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

Index: linux-pm/drivers/acpi/device_pm.c
===================================================================
--- linux-pm.orig/drivers/acpi/device_pm.c
+++ linux-pm/drivers/acpi/device_pm.c
@@ -166,20 +166,20 @@ int acpi_device_set_power(struct acpi_de
 	/* Make sure this is a valid target state */
 
 	if (state == device->power.state) {
-		ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Device is already at %s\n",
+		ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Device [%s] already in %s\n",
+				  device->pnp.bus_id,
 				  acpi_power_state_string(state)));
 		return 0;
 	}
 
 	if (!device->power.states[state].flags.valid) {
-		printk(KERN_WARNING PREFIX "Device does not support %s\n",
-		       acpi_power_state_string(state));
+		dev_warn(&device->dev, "Power state %s not supported\n",
+			 acpi_power_state_string(state));
 		return -ENODEV;
 	}
 	if (device->parent && (state < device->parent->power.state)) {
-		printk(KERN_WARNING PREFIX
-			      "Cannot set device to a higher-powered"
-			      " state than parent\n");
+		dev_warn(&device->dev, "Cannot transition to a higher-powered "
+			 "state than parent\n");
 		return -ENODEV;
 	}
 
@@ -192,8 +192,8 @@ int acpi_device_set_power(struct acpi_de
 
 	if (state < device->power.state && state != ACPI_STATE_D0
 	    && device->power.state >= ACPI_STATE_D3_HOT) {
-		printk(KERN_WARNING PREFIX
-			"Cannot transition to non-D0 state from D3\n");
+		dev_warn(&device->dev,
+			 "Cannot transition to non-D0 state from D3\n");
 		return -ENODEV;
 	}
 
@@ -220,10 +220,8 @@ int acpi_device_set_power(struct acpi_de
 
  end:
 	if (result) {
-		printk(KERN_WARNING PREFIX
-			      "Device [%s] failed to transition to %s\n",
-			      device->pnp.bus_id,
-			      acpi_power_state_string(state));
+		dev_warn(&device->dev, "Failed to change power state to %s\n",
+			 acpi_power_state_string(state));
 	} else {
 		device->power.state = state;
 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,


  parent reply	other threads:[~2013-07-27 13:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-27 13:09 [PATCH 0/3] ACPI / PM: Device PM cleanups Rafael J. Wysocki
2013-07-27 13:10 ` [PATCH 1/3] ACPI / PM: Only set power states of devices that are power manageable Rafael J. Wysocki
2013-07-29 14:09   ` Aaron Lu
2013-07-29 22:21     ` Rafael J. Wysocki
2013-07-29 23:43       ` Aaron Lu
2013-07-30 14:04         ` Rafael J. Wysocki
2013-07-31  6:48           ` Aaron Lu
2013-07-31 10:29             ` Rafael J. Wysocki
2013-07-27 13:11 ` Rafael J. Wysocki [this message]
2013-07-29  2:29   ` [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names Aaron Lu
2013-07-29 12:20     ` Rafael J. Wysocki
2013-07-31  6:52       ` Aaron Lu
2013-07-31 10:27         ` Rafael J. Wysocki
2013-08-01  0:49           ` [PATCH updated] ACPI / PM: Add state information in error message for acpi_device_set_power Aaron Lu
2013-07-29  3:06   ` [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names Lan Tianyu
2013-07-29  3:11     ` Joe Perches
2013-07-29 12:17       ` Rafael J. Wysocki
2013-07-29 12:16         ` Sergei Shtylyov
2013-07-29 13:36           ` Rafael J. Wysocki
2013-07-29 14:15             ` Aaron Lu
2013-07-29 12:11     ` Rafael J. Wysocki
2013-07-27 13:14 ` [PATCH 3/3] ACPI / PM: Use ACPI_STATE_D3_COLD instead of ACPI_STATE_D3 everywhere Rafael J. Wysocki
2013-07-29 14:28   ` Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1895563.95T8SxMegu@vostro.rjw.lan \
    --to=rjw@sisk.pl \
    --cc=aaron.lu@intel.com \
    --cc=bhelgaas@google.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome