From: Jayesh Choudhary <j-choudhary@ti.com>
To: Rob Herring <robh@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<devicetree@vger.kernel.org>, <vigneshr@ti.com>,
<davem@davemloft.net>, <robh+dt@kernel.org>,
<herbert@gondor.apana.org.au>, <j-keerthy@ti.com>
Subject: Re: [PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property
Date: Mon, 1 Aug 2022 10:20:40 +0530 [thread overview]
Message-ID: <1896bceb-2c0d-4c87-4fb6-1e418bf5cef1@ti.com> (raw)
In-Reply-To: <5d9c0f44-efb6-7a1a-e9e4-51a060701ec3@ti.com>
Rob,
On 11/07/22 14:36, Jayesh Choudhary wrote:
> Hi Rob,
>
> On 09/07/22 3:02 am, Rob Herring wrote:
>> On Thu, 07 Jul 2022 16:37:56 +0530, Jayesh Choudhary wrote:
>>> crypto driver itself is not dma-coherent. It is the dmaengine
>>> that moves data and the buffers are to be mapped to the
>>> dmaengine provider. So this property should be dropped.
>>>
>>> Fixes: 2ce9a7299bf6 ('dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation')
>>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
>>> ---
>>> .../devicetree/bindings/crypto/ti,sa2ul.yaml | 13 -------------
>>> 1 file changed, 13 deletions(-)
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings.
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/
>>
>>
>> crypto@4e00000: 'dma-coherent' does not match any of the regexes: '^rng@[a-f0-9]+$', 'pinctrl-[0-9]+'
>> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dtb
>> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dtb
>> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dtb
>> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dtb
>> arch/arm64/boot/dts/ti/k3-am654-base-board.dtb
>> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
>> arch/arm64/boot/dts/ti/k3-j721e-sk.dtb
>>
>
> These warnings are expected. dt-node fixes need to be there.
> I will send the dt-node fixes once this patch gets in due to
> dependency. Or should I proceed any other way?
>
> Thanks,
> Jayesh
This patch is ACKed and there are no other comments.
Can this patch be merged so that I can move forward with dt node
fixes or do you have any other comments on this?
Regards,
Jayesh
next prev parent reply other threads:[~2022-08-01 4:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 11:07 Jayesh Choudhary
2022-07-08 21:32 ` Rob Herring
2022-07-11 9:06 ` Jayesh Choudhary
2022-08-01 4:50 ` Jayesh Choudhary [this message]
2022-07-11 11:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1896bceb-2c0d-4c87-4fb6-1e418bf5cef1@ti.com \
--to=j-choudhary@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=j-keerthy@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®