From: Paul Mackerras <paulus@samba.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Thomas Gleixner <tglx@linutronix.de>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf_counter: extensible perf_counter_attr
Date: Tue, 9 Jun 2009 14:17:03 +1000 [thread overview]
Message-ID: <18989.57919.895309.847520@drongo.ozlabs.ibm.com> (raw)
In-Reply-To: <1244481941.13761.9119.camel@twins>
Peter Zijlstra writes:
> Allow extending the perf_counter_attr structure by linking extended
> structures to it.
...
> @@ -175,6 +175,13 @@ struct perf_counter_attr {
> __u32 __reserved_3;
>
> __u64 __reserved_4;
> +
> + struct perf_counter_attr_ext *ext_attrs;
> +};
Since this is a user-visible structure, you've just introduced an ABI
difference between 32-bit and 64-bit processes, which we've managed to
avoid so far. Assuming that is that you intend eventually to use the
value that userspace puts there, which you don't at the moment. Was
that your intention?
Paul.
next prev parent reply other threads:[~2009-06-09 4:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 17:25 Peter Zijlstra
2009-06-08 19:02 ` Corey Ashford
2009-06-08 19:51 ` Peter Zijlstra
2009-06-08 21:18 ` Corey Ashford
2009-06-08 21:23 ` Peter Zijlstra
2009-06-08 21:29 ` Corey Ashford
2009-06-08 21:50 ` Ingo Molnar
2009-06-09 0:50 ` Corey Ashford
2009-06-09 6:51 ` Ingo Molnar
2009-06-09 8:13 ` Corey Ashford
2009-06-09 11:53 ` Ingo Molnar
2009-06-09 16:44 ` Corey Ashford
2009-06-09 22:00 ` Ingo Molnar
2009-06-09 23:16 ` Corey Ashford
2009-06-10 0:14 ` Paul Mackerras
2009-06-10 22:06 ` Corey Ashford
2009-06-09 4:17 ` Paul Mackerras [this message]
2009-06-09 6:53 ` Ingo Molnar
2009-06-09 9:58 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18989.57919.895309.847520@drongo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=acme@ghostprotocols.net \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®