From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751308AbdCQR5o (ORCPT ); Fri, 17 Mar 2017 13:57:44 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:37155 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbdCQR5k (ORCPT ); Fri, 17 Mar 2017 13:57:40 -0400 X-AuditID: b6c32a2c-f79b56d0000012f0-ff-58cc238b47e2 From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Zapolskiy , Nathan Royce , "# v4 . 10 . x" Subject: Re: [PATCH 1/4] crypto: s5p-sss - Close possible race for completed requests Date: Fri, 17 Mar 2017 18:57:28 +0100 Message-id: <1899144.GIZL8RDvWl@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170317144922.27379-2-krzk@kernel.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsWy7bCmpm638pkIgzXbNC3mnG9hseh+JWNx /vwGdov7934yWVzeNYfNYtGy66wWCzY+YrT4/6uZ2YHDY8vKm0weO2fdZffYdkDVY9OqTjaP fwunsHh83iQXwBbFZZOSmpNZllqkb5fAlfHgwEGWgvOcFdfed7M1MH5i72Lk5JAQMJHYeOM2 lC0mceHeerYuRi4OIYGljBK/nvSxQzjtTBITLmyD6+i/vRIqsZxR4ur0a6wQzldGiRU37zKC VLEJWElMbF8FZosIaEpc//sdrIhZoJdJ4kHHQWaQhLBAuMTPG/dYQGwWAVWJWXOmsYLYvEAN ryZ8BrNFBbwktuxrZwKxOQVMJeYffcQIUSMo8WMyRC+zgLzEvv1TWSFsHYmzx9YxgiyTENjG LrHm3C+gZg4gR1Zi0wFmiBdcJN42f2eBsIUlXh3fAvWatMTfpbcYIezpjBLbf0tAzNnMKLFq 9wSoImuJw8cvQi3jk+j9/QRqPq9ER5sQRImHxK+GT6wQtqPE4m8rwXYJgcz5PoVvAqP8LCQv zELywiwkLyxgZF7FKJZaUJybnlpsWmCoV5yYW1yal66XnJ+7iRGcZrR0djDeW+B9iFGAg1GJ h/eE4pkIIdbEsuLK3EOMEhzMSiK8jSAh3pTEyqrUovz4otKc1OJDjNIcLErivFEGEyOEBNIT S1KzU1MLUotgskwcnFINjKHe6rsM8vomHJEIWWUUtu7y38PsYmFLX18r+pj8cP5x4xl5Ere4 L64SNKnPbVWYc+mlxrHZYRWzflibb/437Wj0VbaLB4/+YT190KEkWHJFUdCBFCH3P9/Ci9c9 X/zi+ks/rqsfbvD9bcpZdrLj/9t+uQAd6VTG/g9sJVyJzLen8pyP+H/FaZ8SS3FGoqEWc1Fx IgCL/G7oLwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t9jAd0u5TMRBitm2ljMOd/CYtH9Ssbi /PkN7Bb37/1ksri8aw6bxaJl11ktFmx8xGjx/1czswOHx5aVN5k8ds66y+6x7YCqx6ZVnWwe /xZOYfH4vEkugC3KzSYjNTEltUghNS85PyUzL91WKTTETddCSSEvMTfVVilC1zckSEmhLDGn FMgzMkADDs4B7sFK+nYJbhkPDhxkKTjPWXHtfTdbA+Mn9i5GTg4JAROJ/tsroWwxiQv31rN1 MXJxCAksZZQ43dnODuF8ZZT4snsCE0gVm4CVxMT2VYwgtoiApsT1v99ZQYqYBfqZJD5tW8QM khAWCJf4eeMeC4jNIqAqMWvONFYQmxeo4dWEz2C2qICXxJZ97WBDOQVMJeYffQQ2VEggXuLT pZOMEPWCEj8mQ8xhFpCX2Ld/KiuErSWxfudxpgmMArOQlM1CUjYLSdkCRuZVjBKpBckFxUnp uUZ5qeV6xYm5xaV56XrJ+bmbGMFx90x6B+PhXe6HGAU4GJV4eG88OR0hxJpYVlyZe4hRgoNZ SYS3UfFMhBBvSmJlVWpRfnxRaU5q8SFGU6AHJzJLiSbnA1NCXkm8oYm5ibmxgYW5paWJkZI4 b+PsZ+FCAumJJanZqakFqUUwfUwcnFINjDVVT/c6XN14Y8k5d+8VD3bF7OoRvK1wx629q3+u osK+uZmJXD4fGDY7/35f9O9B21sHpTOzLiSFzMz5ocxsF6J2Wm+pUduV/Q/P3d+SM6V70tND ZfyRy5SagvW4tt8O2Ljpw86QLafDLnN2Gljd2nZpq03oF9PKqKcBrgkzfl7neyyi4cjL9EuJ pTgj0VCLuag4EQB4PVH70QIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170317175731epcas5p4c078b2e8bfa782fc2bd2a0412f51f03f X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170317175731epcas5p4c078b2e8bfa782fc2bd2a0412f51f03f X-RootMTR: 20170317175731epcas5p4c078b2e8bfa782fc2bd2a0412f51f03f References: <20170317144922.27379-1-krzk@kernel.org> <20170317144922.27379-2-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, March 17, 2017 04:49:19 PM Krzysztof Kozlowski wrote: > Driver is capable of handling only one request at a time and it stores > it in its state container struct s5p_aes_dev. This stored request must be > protected between concurrent invocations (e.g. completing current > request and scheduling new one). Combination of lock and "busy" field > is used for that purpose. > > When "busy" field is true, the driver will not accept new request thus > it will not overwrite currently handled data. > > However commit 28b62b145868 ("crypto: s5p-sss - Fix spinlock recursion > on LRW(AES)") moved some of the write to "busy" field out of a lock > protected critical section. This might lead to potential race between > completing current request and scheduling a new one. Effectively the > request completion might try to operate on new crypto request. > > Cc: # v4.10.x > Fixes: 28b62b145868 ("crypto: s5p-sss - Fix spinlock recursion on LRW(AES)") > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics