From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1761530AbcJ1QPa convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Oct 2016 12:15:30 -0400
Received: from mout.kundenserver.de ([212.227.126.134]:51123 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756302AbcJ1QP2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Oct 2016 12:15:28 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
        Patrick McHardy <kaber@trash.net>,
        Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
        "David S. Miller" <davem@davemloft.net>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        James Morris <jmorris@namei.org>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [rfc, netfilter-next] netfilter: nf_tables: fib warnings
Date: Fri, 28 Oct 2016 18:15:01 +0200
Message-ID: <18995804.9DSMHNUO14@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20161028155031.GI23011@breakpoint.cc>
References: <20161028153124.3773180-1-arnd@arndb.de> <20161028155031.GI23011@breakpoint.cc>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="UTF-8"
X-Provags-ID: V03:K0:oF3VGHlZo6XwlS8DEnHsvoAeFRD+IOM7qOxdDwNC2tgDSAxJrT4
 fQQ/veQ50XPo32xHdJGzb9ks+f9ql4Uzu7ac9N1zrgnBoLaPBHcW5uzhOYPwIdMtGWhJ9zQ
 /UtO+6bVs7no4j60v5+Hn/HwuTYHmvKrp3AWah/hP8BdXF8XMA+c+NfuhUn6VX8Zemu/mfm
 JPuQahy4CRJLGGurJBRYg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:k/5QqJ3H6fs=:y+FzFmCtQGWkXXmCswZeQF
 ZwsCmLAkoTcy586aCi9WhfjDqPtb8J56ZNfwdAfIjtzJrsnTj3a1D43llAeOyBuo3Uvl872j4
 7ID16ud5szXqk25Wj3wHznBilW8oGV/YxpWp1J2JWB2Xib39injVlfxWJTVxgMNj1cyF9+Nil
 YYzSa+C4noL5cqdOFD3JeniiAB4v51YGZtlF6Lh+RV0LjPDxVw3N6JIlQbcRAJl05wzLAjH9s
 rnnJUGH7D1xy3PptJtQiRNxfDwTgMxW1/klMmyObrHIFXohkRCvcPTUn5JKpku1CZpT8qnrio
 ljw3Bq8tgJUsCt3M92FYJr/wM7lWllXqJWpQENLa5mVfOSoM6NodowxizncDzUOwWfmj8XOhu
 5X+F93Mx0TyC+NqRp4/jeVGqgjYBS5ovE82jslXwDl8Ymw4jgUAnd9kvUE/vJy5DRh/v4XzqH
 C8EyX+gDBqzQ4P6llTuo/E9HF3JEDzltzUybMTGIIU5qTPVdsdg/wjZQDTR8eN28xFDei4a2W
 CvMm4ETzBoxDahJsEkzfdAYAyD2oy+C1Q+S9YxRBR9AVf8Zshnq2zK7L/eA9tmFBABQ7r6zrz
 PqSvn4WKu/FPeiFVcP0yxbN6q1Q4N403zhP1HOXu07onOaz9ovHRvzuHaCoHXFOXrRksuHcK0
 Buw6xTghRFH+0HM8ZOiQB0PlXOuYT8UjX05suZYKKOfOR49xRk288soy2TNScBgZTwNYB83bL
 pHm/7mGLevk0wqvn
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, October 28, 2016 5:50:31 PM CEST Florian Westphal wrote:
> Arnd Bergmann <arnd@arndb.de> wrote:
> > The newly added nft fib code produces two warnings:
> > 
> > net/ipv4/netfilter/nft_fib_ipv4.c: In function 'nft_fib4_eval':
> > net/ipv4/netfilter/nft_fib_ipv4.c:80:6: error: unused variable 'i' [-Werror=unused-variable]
> > net/ipv4/netfilter/nft_fib_ipv4.c: In function ‘nft_fib4_eval’:
> > net/ipv4/netfilter/nft_fib_ipv4.c:137:6: error: ‘oif’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> > 
> > The first one is obvious as the only user of that variable is
> > inside of an #ifdef, but the second one is a bit trickier.
> > It is clear that 'oif' is uninitialized here if neither
> > NFTA_FIB_F_OIF nor NFTA_FIB_F_IIF are set.
> > 
> > I have no idea how that should be handled, this patch just
> > returns without doing anything, which may or may not be
> > the right thing to do.
> 
> It should be initialized to NULL.

Ok, I had considered that, but wasn't sure if ->nh_dev could
ever be NULL, as that would then get dereferenced.

	Arnd