mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
	jikos@kernel.org, benjamin.tissoires@redhat.com
Cc: "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override
Date: Fri, 14 Feb 2020 09:32:39 +0100	[thread overview]
Message-ID: <189a7784-3754-99b8-3f3d-560b7657c134@redhat.com> (raw)
In-Reply-To: <20200214065309.27564-1-kai.heng.feng@canonical.com>

Hi,

On 2/14/20 7:53 AM, Kai-Heng Feng wrote:
> The Surfbook E11B uses the SIPODEV SP1064 touchpad, which does not supply
> descriptors, so it has to be added to the override list.
> 
> BugLink: https://bugs.launchpad.net/bugs/1858299
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>   drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> index d31ea82b84c1..a66f08041a1a 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> @@ -341,6 +341,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = {
>   		},
>   		.driver_data = (void *)&sipodev_desc
>   	},
> +	{
> +		.ident = "Trekstor SURFBOOK E11B",
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "TREKSTOR"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "SURFBOOK E11B"),
> +		},
> +		.driver_data = (void *)&sipodev_desc
> +	},
>   	{
>   		.ident = "Direkt-Tek DTLAPY116-2",
>   		.matches = {
> 


  reply	other threads:[~2020-02-14  8:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  6:53 Kai-Heng Feng
2020-02-14  8:32 ` Hans de Goede [this message]
2020-02-14 10:40   ` Benjamin Tissoires
2020-06-15 20:49 Federico Ricchiuto
2020-06-16 11:30 ` Hans de Goede
2020-06-16 15:19   ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=189a7784-3754-99b8-3f3d-560b7657c134@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®