From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-media@vger.kernel.org,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 15/24] media: exynos4-is: Remove call to memset after dma_alloc_coherent
Date: Mon, 15 Jul 2019 13:44:16 +0200 [thread overview]
Message-ID: <189ad2a0-c8ba-54f5-af34-5a0e8efee8fe@samsung.com> (raw)
In-Reply-To: <CABXRUiQ_N=N=weMnRea4d6PXjfghta=U1xhdv-tZpSvaGBnXGg@mail.gmail.com>
On 7/15/19 11:43, Fuqian Huang wrote:
> Should I rewrite the commit log? Just mention that dma_alloc_coherent
> has already zeroed the memory and not to reference the commit?
I don't think it is really needed, since at hash 518a2f1925c3 dma_alloc_coherent()
already zeroes the memory, so in fact all statements in your current commit
message are true.
--
Regards,
Sylwester
next prev parent reply other threads:[~2019-07-15 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 3:18 Fuqian Huang
[not found] ` <CGME20190715090023eucas1p2ab541c5d4b4debe766295d3c6efbd1cd@eucas1p2.samsung.com>
2019-07-15 9:01 ` Sylwester Nawrocki
2019-07-15 9:43 ` Fuqian Huang
2019-07-15 11:44 ` Sylwester Nawrocki [this message]
[not found] ` <CGME20190715114533eucas1p2e63b98faa6d3888df025cedde5bc2696@eucas1p2.samsung.com>
2019-07-15 11:45 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=189ad2a0-c8ba-54f5-af34-5a0e8efee8fe@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=huangfq.daxian@gmail.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®