mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: mixalhs <mike.michalo@gmail.com>
To: Paulo Alcantara <pc@manguebit.org>
Cc: bharathsm@microsoft.com, linkinjeon@kernel.org,
	linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
	ronniesahlberg@gmail.com, samba-technical@lists.samba.org,
	sprasad@microsoft.com,
	syzbot+c2ec61adfbcb24e5ec20@syzkaller.appspotmail.com,
	syzkaller-bugs@googlegroups.com, tom@talpey.com
Subject: Re: [syzbot] [cifs?] KASAN: slab-use-after-free Read in cifs_crypto_secmech_release
Date: Sun, 25 Oct 2026 18:57:49 +0100	[thread overview]
Message-ID: <18D91F35-4165-4679-A3A7-0B8F9A9E0F5E@gmail.com> (raw)
In-Reply-To: <e071a5df45f7ccf80a9d899749e09e11@manguebit.org>

Hi Paulo,

> On 25 Oct 2026, at 18:29, Paulo Alcantara <pc@manguebit.org> wrote:
> 
> Could you please try your reproducer against
> 
>        git://git.manguebit.org/linux.git cifs-next


Done, on cifs-next 9bc48fb48a3, which has Eduard's 77f5fbc2d0af ("smb:
client: hold server info until cifsd exits"). UML x86_64 with KASAN and
PREEMPT, with the same debug msleep(10000) after tcpStatus = CifsExiting
in cifs_put_tcp_session():

 - cifs-next: no KASAN report (the C reproducer once, the Python one
   for 5 rounds).

 - cifs-next with 77f5fbc2d0af reverted: the same slab-use-after-free
   in cifs_crypto_secmech_release() as syzbot, freed by
   clean_demultiplex_info(). So the reproducer still hits the race on
   this tree.

To see both orders of the final put, I added a temporary pr_info() in
cifs_tcp_server_put():

 - with the delay (5 rounds), cifsd drops its reference first in
   clean_demultiplex_info() and cifs_put_tcp_session() frees the server;

 - without the delay (50 rounds), cifs_put_tcp_session() drops its
   reference first and clean_demultiplex_info() frees the server.

No KASAN reports in either case.

Tested-by: Michail Andreas Michalopoulos <mike.michalo@gmail.com>

Thanks,
Michalis



  reply	other threads:[~2026-10-25 17:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20  1:05 syzbot
2026-10-20  4:06 ` Paulo Alcantara
2026-10-20  4:06   ` syzbot
2026-10-24 18:46   ` Michail Andreas Michalopoulos
2026-10-25 17:29     ` Paulo Alcantara
2026-10-25 17:57       ` mixalhs [this message]
2026-10-25 18:05         ` Paulo Alcantara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18D91F35-4165-4679-A3A7-0B8F9A9E0F5E@gmail.com \
    --to=mike.michalo@gmail.com \
    --cc=bharathsm@microsoft.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=samba-technical@lists.samba.org \
    --cc=sprasad@microsoft.com \
    --cc=syzbot+c2ec61adfbcb24e5ec20@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®