From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hari Nagalla <hnagalla@ti.com>,
andersson@kernel.org, devicetree@vger.kernel.org,
mathieu.poirier@linaro.org, p.zabel@pengutronix.de,
linux-remoteproc@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
s-anna@ti.com
Cc: praneeth@ti.com, nm@ti.com, vigneshr@ti.com, a-bhatia1@ti.com,
j-luthra@ti.com, devarsht@ti.com
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: k3-dsp: update bindings for AM62A SoCs
Date: Wed, 28 Dec 2022 13:38:48 +0100 [thread overview]
Message-ID: <18a2fd76-c708-0c14-2d5c-b771ab8baee5@linaro.org> (raw)
In-Reply-To: <20221228123655.15384-2-hnagalla@ti.com>
On 28/12/2022 13:36, Hari Nagalla wrote:
> The TI AM62A SoCs have a C7xv DSP and Analytics engine for deep
> learning purposes. The DSP part is similar to the C71x DSP found on
> K3 J7 SoCs, but additional hardware accelerators and IP are added to
> the subsystem for deep learning.
>
> Compatible info is updated to match AM62A SoCs.
>
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
> .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index cedbc5efdc56..846c9c14169a 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -34,10 +34,12 @@ properties:
> - ti,j721e-c66-dsp
> - ti,j721e-c71-dsp
> - ti,j721s2-c71-dsp
> + - ti,am62a-c7xv-dsp
Add it in some order, e.g. alphabetical.
> description:
> Use "ti,j721e-c66-dsp" for C66x DSPs on K3 J721E SoCs
> Use "ti,j721e-c71-dsp" for C71x DSPs on K3 J721E SoCs
> Use "ti,j721s2-c71-dsp" for C71x DSPs on K3 J721S2 SoCs
> + Use "ti,am62a-c7xv-dsp" for AM62A Deep learning DSPs on K3 AM62A SoCs
>
> resets:
> description: |
> @@ -111,6 +113,7 @@ else:
> enum:
> - ti,j721e-c71-dsp
> - ti,j721s2-c71-dsp
> + - ti,am62a-c7xv-dsp
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Wrong indentation.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-28 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 12:36 [PATCH 0/2] Add C7xv DSP for AM62A Hari Nagalla
2022-12-28 12:36 ` [PATCH 1/2] dt-bindings: remoteproc: k3-dsp: update bindings for AM62A SoCs Hari Nagalla
2022-12-28 12:38 ` Krzysztof Kozlowski [this message]
2022-12-30 13:21 ` Hari Nagalla
2022-12-28 17:16 ` Rob Herring
2022-12-28 12:36 ` [PATCH 2/2] remoteproc: k3-c7x: Add support for C7xv DSP on AM62A SoC Hari Nagalla
2022-12-28 13:32 ` Raghavendra, Vignesh
2022-12-30 13:22 ` Hari Nagalla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18a2fd76-c708-0c14-2d5c-b771ab8baee5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a-bhatia1@ti.com \
--cc=andersson@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=j-luthra@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®