From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2B312848AA for ; Wed, 24 Dec 2025 07:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766560244; cv=none; b=K5WIx/RYB6ZHrFUjVsqPigHvHST4oV9NOda10eD+iXmg0FwD3aBO8YJfMoGpEYEWSaMf2UqgsqM38VKG5mkl2nj7cLqQ6ORkfuP9dUf/y3ErDs7Ar2TvJcdOp+0IT36kgj65jHxQ3bHtyXyCNzeUm6KjW3yUGXBz73KAY65CVd8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766560244; c=relaxed/simple; bh=7A5dqrMOK0w+O/9LCKXhmJ0MZxcWq7Nmd/wG7Ogf/v8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pis2WFfbqNVgl7dyfKxAFUkXoWFmRtSmR7Mzi4gzQKuIZCZMUeR/TIXZR+PhRfSduhqTU0xbqplBxVOiBmDkWbaHhLJnB0NUmfOjA0PSOI8jzPZLKUYbiL6XwgcnyLz/Kew34edbNaTlULtzVClJOICT2ahXpzj27HOlLUvUf1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W8lV7157; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ijl5P+z6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W8lV7157"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ijl5P+z6" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO0Csn4559749 for ; Wed, 24 Dec 2025 07:10:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 71gXKtFW7Gx6s5o4kXmxuGUOzAnZR1zYbg0J94tOxuk=; b=W8lV71577kokZIE9 VHIE1D68vmYiVEopRprRRcRmoQQQtFqBy2GgyWFHrIxcVWJ33U2cYYzYcqZ01p3H O69x10bn1kWL1WdYfPmLvLU1m9w28hqjUgRG01dh34SJYxuwY6qKgc9JGMWpNMmN snbTebatHMcPJPZOZbWmMVTqFTicbJRlQn3AAWwn6phpwreRdR8yctHDwBd5FoeX PFsXkwtluQgdhfBl3N0WOL7yyfkaqHNu9s3Ke2x2M98rzNFSdZOC/tsao82rOx64 44t6CmTnLlxdamfTHhhbqOT8qS5dTvINYvI+Bc/87pNtK9dRUKmWWWyBJjbr8uPi aABUeQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7u9ctrws-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 07:10:41 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34e70e2e363so12008813a91.1 for ; Tue, 23 Dec 2025 23:10:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766560240; x=1767165040; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=71gXKtFW7Gx6s5o4kXmxuGUOzAnZR1zYbg0J94tOxuk=; b=ijl5P+z6e/9pNDmh3J/rvKqyZGS/e7Y/B653jBUZ5MZkI4ftzXXFFtpteG85paaH4x 1ESemLRffzvPfStGp8oNTHeyiOcTo6YXhU1RQ88Jo6zLBfKeG5z6mqbsE47YXi/i3Z9D qCMrs3PS71h1FnMMOwuTJ706erCrTlsZa2CukzF3KG3jLzKb8q0AtQbJKG5/F5dv0h2d PhQ8HmrSkEhw+p1By4p7DD5FAxAj3L8+U7gWv8ePrCeKxnZWzIvmlKm9VuxkHEc7wsz+ 9vuitLlwRjpoqXDLrBonk2/740ck2poo/tT0A6rkHxD0AcAXJ+82crghdNaoqxy6h6I2 VQCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766560240; x=1767165040; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=71gXKtFW7Gx6s5o4kXmxuGUOzAnZR1zYbg0J94tOxuk=; b=jicKUbSLkQYbOPgp8d09IVev5tZhZZ8e7wbsPwbdzDGgAmiG/cOIundTDf+BmNrtkm +IMgkqsa0kL2Z7tJcJJGcQ+bd9+bpt3qrRAXh2b7jvOV9g1LEVG3eCxXBG1jTqtoG8Qa Z43fJs5h5DDv2gk9lGdGgtuS3fsu6BcdjzRUmP4SHcEJONx+Jsqx+VhYKLyJUgoCKHCt RV+CH3aPC4to5gvGvk4bTDvkI13NmRR/9kVmhFUHhfjKcOYDQFnWABy6IKRXSJZ9xf2W hExvdTRvRc6Z/iQFY2tm+ObhUB7T4woTlsNK6iWH6/lrq9A1vWcHEFzYKvs7SW04P05m WGcw== X-Gm-Message-State: AOJu0YydZKAhJi8HOTTlMFKs+6nKuKyIDTr0f+95yVFaM4WLqVOJiBGE KE25Ic52Hjbuxdw46au11Ev3HWDYveLxWV2OmjPO6Mfc6JBu4VLYTljRryMIIRyp78ND4w3giV3 IWJRh9vj4PPa/K928wSGCp8ldzKtvBBECpnGbjFWinfF8vzsFWYtbhujmReMPeTIbrFckUv0Fwh 3G6Q== X-Gm-Gg: AY/fxX7z4hPxCyHCFXSJ+SEPH62t/Oa/zPCinb1AiwR3gNCaEtxZnl9s5r3sJYAAgfV chFvEPP3Vyh9C01dRu3Rp5l2FLiH5bOlYBD9vgAklKFZZmYF2iWTx473GlAcze6baEFYOYkV52z YBrfxZYUYwwxMjfv9j88WRMkIP/RzTrdKrc/t2/ir614+tzgaWpBhMrp8sJ354AHCynA2BCaf0s wvmK+5USS2JUDZYoFIv7jfeSLMV+qRpQd13+AQ8tMl77YMsYVtAHhYYJ/NdClsIfBaAiTU1atIy MJTGrfPEiouyh/QryMH44DiyywAVw6fKOMEGP2jxvNMtrd4iWBmeaexAqyrTbBbwRax8meYgzPd Rrqtz0aXniieda3fvua+jsLO4/sDf0Xz7HUNN33FgdK0gs0lwn9xyuZKfCe1IFMky+Dwe6uP1gM sjXOne X-Received: by 2002:a17:90b:3145:b0:32d:d5f1:fe7f with SMTP id 98e67ed59e1d1-34e92142cb5mr15260133a91.15.1766560240124; Tue, 23 Dec 2025 23:10:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IETyNPMDm3Y3pott9MwYCmEvde6P/jTze/LD6TVCgKspnpHFALg+ERFj5vn0NqfBMpF9mribg== X-Received: by 2002:a17:90b:3145:b0:32d:d5f1:fe7f with SMTP id 98e67ed59e1d1-34e92142cb5mr15260108a91.15.1766560239632; Tue, 23 Dec 2025 23:10:39 -0800 (PST) Received: from [10.133.33.224] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1e7bd61b40sm13978815a12.23.2025.12.23.23.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Dec 2025 23:10:39 -0800 (PST) Message-ID: <18a5d332-7ba3-47aa-bee9-1e5f5b724b80@oss.qualcomm.com> Date: Wed, 24 Dec 2025 15:10:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] serial: core: Fix serial device initialization To: Alexander Stein , Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Cosmin Tanislav References: <20251219152813.1893982-1-alexander.stein@ew.tq-group.com> Content-Language: en-US From: Jingyi Wang In-Reply-To: <20251219152813.1893982-1-alexander.stein@ew.tq-group.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: O4dShApUITyGNoVGgPz8Ck3gEsiY7aWv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDA2MCBTYWx0ZWRfX+CyqqN1Ol6lo lFoXyFd3FUSagshBQg+ovUPVMR6H0mBYv5q8xI6TJXtkhNynSWAZ+mGZpeszLRm3NVDgYwKbjU5 +1rSNnMqKcz4h6hXwgHPffz9uEtUpqBK0F9kN67CX84PD/8Wz+YZwsf0OGHcxIZZAjSUBSvV9ps nUkQrE18ivcUBxmZB5bl+74FcjlNsFPpEMN6A/TMm5Ge6SE+GLqbj2pDUsHsNohz5NU+aC3XQiP d6mZvtE4+Fkt284Hd5jT6tMlUsnbwmFJoSqNZ4loRTkGs6e6BtvU4IJyNIrSm5Gc8tYvfLTd6M8 0N7SmRIjrd3LhqoKM5dAld4XJPXFEk62VCqNEnULrujbejDR07OrvJ8DkS4nseWCSZJfezPK7+o 1JCbJe0vAKkukGDeeMQojSj6jDeNQYXiWyNkHUcmOzSlRubTkxWiyd1iY189JRpT0SxfzGm6kN0 JJHcQqD9BqEiJfrFw8w== X-Authority-Analysis: v=2.4 cv=HsN72kTS c=1 sm=1 tr=0 ts=694b91f1 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=8f9FM25-AAAA:8 a=9xdg8cEAAQnOrwX93C8A:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=uSNRK0Bqq4PXrUp6LDpb:22 X-Proofpoint-ORIG-GUID: O4dShApUITyGNoVGgPz8Ck3gEsiY7aWv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_02,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 clxscore=1015 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240060 On 12/19/2025 11:28 PM, Alexander Stein wrote: > During restoring sysfs fwnode information the information of_node_reused > was dropped. This was previously set by device_set_of_node_from_dev(). > Add it back manually > > Fixes: 24ec03cc5512 ("serial: core: Restore sysfs fwnode information") > Suggested-by: Cosmin Tanislav > Signed-off-by: Alexander Stein > --- > drivers/tty/serial/serial_base_bus.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/serial_base_bus.c b/drivers/tty/serial/serial_base_bus.c > index 8e891984cdc0d..1e1ad28d83fcf 100644 > --- a/drivers/tty/serial/serial_base_bus.c > +++ b/drivers/tty/serial/serial_base_bus.c > @@ -74,6 +74,7 @@ static int serial_base_device_init(struct uart_port *port, > dev->parent = parent_dev; > dev->bus = &serial_base_bus_type; > dev->release = release; > + dev->of_node_reused = true; > > device_set_node(dev, fwnode_handle_get(dev_fwnode(parent_dev))); > This can fix the broken serial on the Qualcomm Kaanapali device on the latest tag. Thanks, Jingyi