From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3681C433E0 for ; Wed, 12 Aug 2020 02:01:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABAC8206C3 for ; Wed, 12 Aug 2020 02:01:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726512AbgHLCBJ (ORCPT ); Tue, 11 Aug 2020 22:01:09 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:41904 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726235AbgHLCBJ (ORCPT ); Tue, 11 Aug 2020 22:01:09 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id B315B9617494B5F5982D; Wed, 12 Aug 2020 10:01:05 +0800 (CST) Received: from [10.164.122.247] (10.164.122.247) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 12 Aug 2020 10:01:04 +0800 Subject: Re: [PATCH] erofs: avoid duplicated permission check for "trusted." xattrs To: Gao Xiang , CC: LKML , Chao Yu , Hongyu Jin , References: <20200811070020.6339-1-hsiangkao@redhat.com> From: Chao Yu Message-ID: <18a6a9b7-5967-1929-920a-e34e446944ac@huawei.com> Date: Wed, 12 Aug 2020 10:01:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200811070020.6339-1-hsiangkao@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.164.122.247] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/8/11 15:00, Gao Xiang wrote: > Don't recheck it since xattr_permission() already > checks CAP_SYS_ADMIN capability. > > Just follow 5d3ce4f70172 ("f2fs: avoid duplicated permission check for "trusted." xattrs") > > Reported-by: Hongyu Jin > [ Gao Xiang: since it could cause some complex Android overlay > permission issue as well on android-5.4+, so it'd be better to > backport to 5.4+ rather than pure cleanup on mainline. ] > Cc: # 5.4+ > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,