From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Salomon Dushimirimana <salomondush@google.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: Add SCSI error events, sent as kobject uevents by mid-layer
Date: Tue, 13 May 2025 16:27:33 -0400 [thread overview]
Message-ID: <18aa42a73584fcf50b07d7a43073e55fb4c3159b.camel@HansenPartnership.com> (raw)
In-Reply-To: <CAPE3x14-Tsm-2ThihT3a=h9a0L9Vi8J4BbiZiTV6=6Ctc1xryg@mail.gmail.com>
On Tue, 2025-05-13 at 12:00 -0700, Salomon Dushimirimana wrote:
> Hi James and Martin
>
> I wanted to follow up on this patch! It's a decently sized patch, so
> it might take some time, but I'd love to hear your thoughts and
> address any feedback!!
I think the first fundamental question should be why is this a uevent?
It looks like what you're obtaining is really tracing information on
the retry and we could simply add it as another tracepoint in the
existing blktrace infrastructure SCSI already has.
Regards,
James
next prev parent reply other threads:[~2025-05-13 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 18:17 Salomon Dushimirimana
2025-05-13 19:00 ` Salomon Dushimirimana
2025-05-13 20:27 ` James Bottomley [this message]
2025-05-15 20:03 ` Salomon Dushimirimana
2025-05-15 20:11 ` James Bottomley
2025-06-09 19:02 ` Salomon Dushimirimana
2025-05-13 19:39 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18aa42a73584fcf50b07d7a43073e55fb4c3159b.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=salomondush@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®