From: Paul Moore <paul@paul-moore.com>
To: Eiichi Tsukata <eiichi.tsukata@nutanix.com>,
eparis@redhat.com, linux-kernel@vger.kernel.org,
audit@vger.kernel.org
Subject: Re: [PATCH v2 2/5] audit: account backlog waiting time in audit_receive()
Date: Fri, 19 May 2023 16:54:38 -0400 [thread overview]
Message-ID: <18aac53d73e41b33b71d9e5d0f5d4286.paul@paul-moore.com> (raw)
In-Reply-To: <20230511052116.19452-3-eiichi.tsukata@nutanix.com>
On May 11, 2023 Eiichi Tsukata <eiichi.tsukata@nutanix.com> wrote:
>
> Currently backlog waiting time in audit_receive() is not accounted as
> audit_backlog_wait_time_actual. Accounts it as well.
>
> Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
> ---
> kernel/audit.c | 44 ++++++++++++++++++++++++++------------------
> 1 file changed, 26 insertions(+), 18 deletions(-)
The audit_receive() wait is different from that in audit_log_start()
as processes calling into audit_receive() are performing an explicit
audit operation whereas those processes calling audit_log_start() are
likely doing something else, e.g. opening a file, that happens to
result in an audit record being generated. The fact that the
audit_receive() accounting logic, as well as the timeout calculation
used, is different from audit_log_start() is intentional.
--
paul-moore.com
next prev parent reply other threads:[~2023-05-19 20:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 5:21 [PATCH v2 0/5] audit: refactors and fixes for potential deadlocks Eiichi Tsukata
2023-05-11 5:21 ` [PATCH v2 1/5] audit: refactor queue full checks Eiichi Tsukata
2023-05-19 20:54 ` Paul Moore
2023-05-22 4:19 ` Eiichi Tsukata
2023-05-11 5:21 ` [PATCH v2 2/5] audit: account backlog waiting time in audit_receive() Eiichi Tsukata
2023-05-19 20:54 ` Paul Moore [this message]
2023-05-22 4:22 ` Eiichi Tsukata
2023-05-23 20:55 ` Paul Moore
2023-05-11 5:21 ` [PATCH v2 3/5] audit: convert DECLARE_WAITQUEUE to DEFINE_WAIT Eiichi Tsukata
2023-05-19 20:54 ` Paul Moore
2023-05-11 5:21 ` [PATCH v2 4/5] audit: check if audit_queue is full after prepare_to_wait_exclusive() Eiichi Tsukata
2023-05-19 20:54 ` Paul Moore
2023-05-22 4:28 ` Eiichi Tsukata
2023-05-23 21:02 ` Paul Moore
2023-05-11 5:21 ` [PATCH v2 5/5] audit: do not use exclusive wait in audit_receive() Eiichi Tsukata
2023-05-19 20:54 ` Paul Moore
2023-05-22 4:44 ` Eiichi Tsukata
2023-05-23 3:58 ` Eiichi Tsukata
2023-05-23 21:07 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18aac53d73e41b33b71d9e5d0f5d4286.paul@paul-moore.com \
--to=paul@paul-moore.com \
--cc=audit@vger.kernel.org \
--cc=eiichi.tsukata@nutanix.com \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®