From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DAB6C433EF for ; Mon, 11 Apr 2022 01:53:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244324AbiDKBzd (ORCPT ); Sun, 10 Apr 2022 21:55:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232575AbiDKBzb (ORCPT ); Sun, 10 Apr 2022 21:55:31 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B4796179 for ; Sun, 10 Apr 2022 18:53:18 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KcBdn50mxzFpc3; Mon, 11 Apr 2022 09:50:53 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 11 Apr 2022 09:53:16 +0800 Subject: Re: [PATCH v2 3/9] mm/vmscan: introduce helper function reclaim_page_list() To: Matthew Wilcox CC: , , , , , References: <20220409093500.10329-1-linmiaohe@huawei.com> <20220409093500.10329-4-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <18ac3908-d162-f1ea-e91f-1da203272b74@huawei.com> Date: Mon, 11 Apr 2022 09:53:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/4/9 21:44, Matthew Wilcox wrote: > On Sat, Apr 09, 2022 at 05:34:54PM +0800, Miaohe Lin wrote: >> + nr_reclaimed = shrink_page_list(page_list, pgdat, &sc, &dummy_stat, false); >> + while (!list_empty(page_list)) { >> + folio = lru_to_folio(page_list); >> + list_del(&folio->lru); >> + putback_lru_page(&folio->page); > > folio_putback_lru() I thought folio_putback_lru is deliberately not to use because there is no caller of folio_putback_lru now. But it seems I was wrong. Will do it in next version. Thanks a lot! > > . >