From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D68CCA48B for ; Sun, 24 Jul 2022 18:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231817AbiGXS2B (ORCPT ); Sun, 24 Jul 2022 14:28:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229977AbiGXS17 (ORCPT ); Sun, 24 Jul 2022 14:27:59 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D3C010557 for ; Sun, 24 Jul 2022 11:27:58 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id x23-20020a05600c179700b003a30e3e7989so5196293wmo.0 for ; Sun, 24 Jul 2022 11:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linexp-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:content-language:to:cc :references:from:subject:in-reply-to:content-transfer-encoding; bh=qt1aI68JPk+yFMgieLmwwFbYBpyY4LDiXmO9WB/LvSU=; b=tzrGLmAQ89B4gqHZfsNPAiZ3PRHVJftO8zQt//3j9sGVDEI9Bh1rbSa6dw6cJ6ipkg iKLzn9lHpOgrPLU8rjHVn3DG3Tdf7DXyTHjoIV3LqToc7dBKiyyCHS8yLFsYuJ1UDVnV 9JzChKeXmrlrPmHc2RZ5aD1/ZOo54nhZFg70wj2g2HF4VKZcllgS3gWDZye3AjI28aWo p2CkSGy82Wg2ovRrlYEpt9Nj5QZ88G+7OajBkN2YAnFWLg4f81Zqk0mpIc7RTsbzPI/y CM7jIq3X2DF0s9TyiK8BEPKKtCQQiKZT1guBLz13QgJJJXDmhTvx6+tWodcv2mFMGaHO OUkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=qt1aI68JPk+yFMgieLmwwFbYBpyY4LDiXmO9WB/LvSU=; b=PTa99WEhbaujle/OrnPoK5c7RrgAqz0Y4HsyQ3CcV5V45o1o8fJtnwgWrfF7vu0oyt HZe2k4+6UIKtzPBpj1O4IvZdLywB17WVeJyGvJ5Fh9Ly84hRVxBCOXJLjkuqK5lxlB2o XQH9rVBJak8OqP3DkKT7G7Ib+LOEkVdjwbaexTK9ri1k3VM1WqhtgIbQH1jibd/biBlx 72dDJ00Gl6WsG/Q3CnArPmE1q9R/CoshW3JKxL8siQhbxk5PimkNPj8dO3rvjr98fJRe S6pZjZ7aSSucuIDnGFAfuTjYuOMegeHa1Nt6U9uAw3pZD3laVJJYznEYJ/yiB5P+sQ0A 95sQ== X-Gm-Message-State: AJIora+ilQvdkx4n6BS46SfKcgO2jVogc/H/KwIQHbx9OfLrT/4YWk5D r6+5MnOE61xtpZ41P0UUOGos07oWTws96A== X-Google-Smtp-Source: AGRyM1sjq6r4lCCXcIRAD2gAykcxk/ihD6ntTZG2GPA59qR4zIAwbQZPeCh4DrsvPKk2AM7HiNYswQ== X-Received: by 2002:a05:600c:a47:b0:39e:f953:84e2 with SMTP id c7-20020a05600c0a4700b0039ef95384e2mr18497105wmq.202.1658687276763; Sun, 24 Jul 2022 11:27:56 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:feb7:6a58:3e0f:a58f? ([2a05:6e02:1041:c10:feb7:6a58:3e0f:a58f]) by smtp.gmail.com with ESMTPSA id s2-20020adff802000000b0021e4edba1e5sm10102085wrp.111.2022.07.24.11.27.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Jul 2022 11:27:56 -0700 (PDT) Message-ID: <18ade2d0-ebda-0526-71f3-65a0b2685068@linexp.org> Date: Sun, 24 Jul 2022 20:27:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= Cc: daniel.lezcano@linaro.org, rafael@kernel.org, rui.zhang@intel.com, khilman@baylibre.com, abailon@baylibre.com, amitk@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "open list:RENESAS R-CAR THERMAL DRIVERS" References: <20220710212423.681301-1-daniel.lezcano@linexp.org> <20220710212423.681301-18-daniel.lezcano@linexp.org> From: Daniel Lezcano Subject: Re: [PATCH v1 17/33] thermal/drivers/rcar: Switch to new of API In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Niklas, I tried to reproduce the issue but without success. What sensor are you using ? On 19/07/2022 11:10, Niklas Söderlund wrote: > Hi Daniel, > > Thanks for your work. > > On 2022-07-10 23:24:07 +0200, Daniel Lezcano wrote: >> The thermal OF code has a new API allowing to migrate the OF >> initialization to a simpler approach. >> >> Use this new API. > I tested this together with the series it depends on and while > temperature monitoring seems to work fine it breaks the emul_temp > interface (/sys/class/thermal/thermal_zone2/emul_temp). > > Before this change I can write a temperature to this file and have it > trigger actions, in my test-case changing the cooling state, which I > observe in /sys/class/thermal/cooling_device0/cur_state. > > Likewise before this change I could trip the critical trip-point that > would power off the board using the emul_temp interface, this too no > longer works, > > echo 120000 > /sys/class/thermal/thermal_zone2/emul_temp > > Is this an intention change of the new API?