From: Richard Gong <richard.gong@linux.intel.com>
To: Dinh Nguyen <dinguyen@kernel.org>,
gregkh@linuxfoundation.org, catalin.marinas@arm.com,
will.deacon@arm.com, robh+dt@kernel.org, mark.rutland@arm.com,
atull@kernel.org, mdf@kernel.org, arnd@arndb.de, corbet@lwn.net
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org,
yves.vandervennet@linux.intel.com, richard.gong@intel.com
Subject: Re: [PATCHv8 7/9] defconfig: enable fpga and service layer
Date: Thu, 30 Aug 2018 09:05:55 -0500 [thread overview]
Message-ID: <18b2948c-07dc-dc23-6a36-04e8295705f3@linux.intel.com> (raw)
In-Reply-To: <54ccf9d5-1cf4-edf6-47c6-be7cc5badb3e@kernel.org>
On 08/28/2018 09:11 AM, Dinh Nguyen wrote:
>
>
> On 08/28/2018 08:50 AM, richard.gong@linux.intel.com wrote:
>> From: Richard Gong <richard.gong@intel.com>
>>
>> Enable fpga framework, Stratix 10 SoC FPGA manager and Stratix10
>> Service Layer
>>
>
> Please update your commit header be "arm64: defconfig: enable fpga and
> service layer"
Ok, I will make update in the next submission.
>
>
>> Signed-off-by: Richard Gong <richard.gong@intel.com>
>> Signed-off-by: Alan Tull <atull@kernel.org>
>> ---
>> v2: this patch is added in patch set version 2
>> v3: no change
>> v4: s/CONFIG_INTEL_SERVICE/CONFIG_STRATIX10_SERVICE/
>> add CONFIG_OF_FPGA_REGION=y
>> s/Intel/Stratix10/ in subject line
>> v5: no change
>> v6: no change
>> v7: no change
>> v8: no change
>> ---
>> arch/arm64/configs/defconfig | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index f67e8d5..2ad50a5 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -185,6 +185,7 @@ CONFIG_BLK_DEV_LOOP=y
>> CONFIG_BLK_DEV_NBD=m
>> CONFIG_VIRTIO_BLK=y
>> CONFIG_BLK_DEV_NVME=m
>> +CONFIG_STRATIX10_SERVICE=y
>
> Can this be a module?
No, Service layer driver need be compiled as part of kernel image.
Service layer driver provides services for service clients, it must be
loaded & initialized before service clients (FPGA manager and remote
status update drivers).
>
>> CONFIG_SRAM=y
>> CONFIG_EEPROM_AT25=m
>> # CONFIG_SCSI_PROC_FS is not set
>> @@ -642,6 +643,12 @@ CONFIG_PHY_TEGRA_XUSB=y
>> CONFIG_HISI_PMU=y
>> CONFIG_QCOM_L2_PMU=y
>> CONFIG_QCOM_L3_PMU=y
>> +CONFIG_MESON_EFUSE=m
>
> What does this change have to do with this patch?
My mistake, I will fix in the next submission.
>
>> +CONFIG_FPGA=y
>> +CONFIG_FPGA_MGR_STRATIX10_SOC=y
>> +CONFIG_FPGA_REGION=y
>> +CONFIG_FPGA_BRIDGE=y
>> +CONFIG_OF_FPGA_REGION=y
>
> Can these be modules?
CONFIG_FPGA_MGR_STRATIX10_SOC could be module, but the remaining
components need be compiled as part of kernel image.
>
> Dinh
>
next prev parent reply other threads:[~2018-08-30 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 13:50 [PATCHv8 0/9] Add Intel Stratix10 FPGA manager " richard.gong
2018-08-28 13:50 ` [PATCHv8 1/9] dt-bindings, firmware: add Intel Stratix10 service layer binding richard.gong
2018-08-28 13:50 ` [PATCHv8 2/9] arm64: dts: stratix10: add stratix10 service driver binding to base dtsi richard.gong
2018-08-28 13:50 ` [PATCHv8 3/9] misc: add Intel Stratix10 service layer driver richard.gong
2018-08-28 13:50 ` [PATCHv8 4/9] dt-bindings: fpga: add Stratix10 SoC FPGA manager binding richard.gong
2018-08-28 13:50 ` [PATCHv8 5/9] arm64: dts: stratix10: add fpga manager and region richard.gong
2018-08-28 13:50 ` [PATCHv8 6/9] fpga: add intel stratix10 soc fpga manager driver richard.gong
2018-08-28 13:50 ` [PATCHv8 7/9] defconfig: enable fpga and service layer richard.gong
2018-08-28 14:11 ` Dinh Nguyen
2018-08-30 14:05 ` Richard Gong [this message]
2018-08-28 13:50 ` [PATCHv8 8/9] Documentation: driver-api: add stratix10 " richard.gong
2018-08-28 13:50 ` [PATCHv8 9/9] misc: add remote status update client support richard.gong
-- strict thread matches above, loose matches on Subject: below --
2018-07-26 16:27 [PATCHv8 0/9] Add Intel Stratix10 FPGA manager and service layer richard.gong
2018-07-26 16:27 ` [PATCHv8 7/9] defconfig: enable fpga " richard.gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18b2948c-07dc-dc23-6a36-04e8295705f3@linux.intel.com \
--to=richard.gong@linux.intel.com \
--cc=arnd@arndb.de \
--cc=atull@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=yves.vandervennet@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®