Re: [PATCH 1/2] PCI: dwc: rcar-gen4: Replace pe_rst GPIO PERST with GPIO reset aux driver

[Marek Vasut <marek.vasut@mailbox.org>]

On 10/28/26 6:21 PM, Marek Vasut wrote:

[...]

> 1) Combined mandatory PCIe core resets and optional GPIO PERST#:
>     pciec@nnn {
>         compatible = "renesas,r8a779g0-pcie", "renesas,rcar-gen4-pcie";
>         ...
>         resets = <&reset 624>, <&reset 1121>;
>         reset-names = "pwr", "core";
>         reset-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; // This is GPIO PERST#
>         ...
>     };

[...]

> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 12f102f48d5d5..b09c01853d807 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -104,10 +104,6 @@ static int dw_pcie_get_resets(struct dw_pcie *pci)
>   	if (ret)
>   		return ret;
>   
> -	pci->pe_rst = devm_gpiod_get_optional(pci->dev, "reset", GPIOD_OUT_HIGH);
> -	if (IS_ERR(pci->pe_rst))
> -		return PTR_ERR(pci->pe_rst);
Bartosz, alternatively, I wonder if there is any way to request the 
reset-gpios as reset controller reset here already. That might be even 
cleaner, but I don't think there is anything like 
devm_reset_control_bulk_get_optional_exclusive_and_also_request_the_gpio_reset() 
or devm_reset_control_get_optional_exclusive_gpio_reset() . Maybe 
something like that could be added to the reset subsystem instead ?

Thank you for your help !