From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 694F8C46467 for ; Tue, 10 Jan 2023 04:22:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbjAJEWN (ORCPT ); Mon, 9 Jan 2023 23:22:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbjAJEWC (ORCPT ); Mon, 9 Jan 2023 23:22:02 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8742D40C12; Mon, 9 Jan 2023 20:22:01 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30A4JQpM018120; Tue, 10 Jan 2023 04:21:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=4LrIcSBrZofZ63AuOobSYBE1QpzemocgIadGp/OUNN8=; b=lqae9isyUZ4/DeXBv+scU/dVlEbFd4eSUdtUuKLeAtDhUs2lpCfA/FWF32XBH0/cPtxf Uc0fJpJNpKDjjQH771OY6TY8iNF/4KQ7nF/MXYZmA0Mz4YDim9DBrLs8idpmuQnOhwFo ZIWi9yx08VnPdpw54a/IY1YA+jbf3/WvtFyTyXIZndES/joQKkwP/rt4VEtC9+K9R7eJ u02U/b/FhjEkhPQ0IhXK8eq/TqrTWL6N+B1dekPz88R6SVh8eJksIoVuePgQxJtMsokd DfwFzf/8aTtdkztGxMAzcESVW+2Cd3fGKPrDJzKJcaMJNEBxO1Uq16u9yEgcw6d4fxJP og== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n0q2as261-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jan 2023 04:21:52 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30A4LpHU025888 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jan 2023 04:21:51 GMT Received: from [10.131.117.203] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 9 Jan 2023 20:21:48 -0800 Message-ID: <18c2bd9a-0216-c4fc-773e-601aea030b48@quicinc.com> Date: Tue, 10 Jan 2023 09:51:39 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards Content-Language: en-US To: Doug Anderson , Dmitry Baryshkov CC: , Matthias Kaehlcke , , , , , , , References: <20221216112918.1243-1-quic_rjendra@quicinc.com> <9f6bd192-2a42-0a23-0032-df8b01921bdc@linaro.org> From: Rajendra Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 4BpskncCuUht8ZoQE5tvlJUTcumdZapf X-Proofpoint-ORIG-GUID: 4BpskncCuUht8ZoQE5tvlJUTcumdZapf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-09_16,2023-01-09_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 clxscore=1011 adultscore=0 impostorscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301100026 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/10/2023 3:12 AM, Doug Anderson wrote: > Hi, > > On Mon, Jan 9, 2023 at 1:36 PM Dmitry Baryshkov > wrote: >> >> On 09/01/2023 23:00, Doug Anderson wrote: >>> Hi, >>> >>> On Tue, Dec 20, 2022 at 9:12 AM Dmitry Baryshkov >>> wrote: >>>> >>>> On 20/12/2022 18:20, Rajendra Nayak wrote: >>>>> >>>>> >>>>> On 12/20/2022 8:00 PM, Matthias Kaehlcke wrote: >>>>>> On Tue, Dec 20, 2022 at 10:30:32AM +0530, Rajendra Nayak wrote: >>>>>>> >>>>>>> On 12/16/2022 7:49 PM, Matthias Kaehlcke wrote: >>>>>>>> On Fri, Dec 16, 2022 at 04:59:17PM +0530, Rajendra Nayak wrote: >>>>>>>>> Add compatibles for the Pro SKU of the sc7280 CRD boards >>>>>>>>> which come with a Pro variant of the qcard. >>>>>>>>> The Pro qcard variant has smps9 from pm8350c ganged up with >>>>>>>>> smps7 and smps8. >>>>>>>>> >>>>>>>>> Signed-off-by: Rajendra Nayak >>>>>>>>> Acked-by: Krzysztof Kozlowski >>>>>>>>> Reviewed-by: Matthias Kaehlcke >>>>>>>>> --- >>>>>>>>> v4 changes: >>>>>>>>> Added the zoglin-sku1536 compatible along with hoglin-sku1536. >>>>>>>>> Zoglin is same as the Hoglin variant, with the SPI Flash reduced >>>>>>>>> from 64MB to 8MB >>>>>>>>> >>>>>>>>> Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ >>>>>>>>> 1 file changed, 6 insertions(+) >>>>>>>>> >>>>>>>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml >>>>>>>>> b/Documentation/devicetree/bindings/arm/qcom.yaml >>>>>>>>> index 1b5ac6b02bc5..07771d4c91bd 100644 >>>>>>>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >>>>>>>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >>>>>>>>> @@ -558,6 +558,12 @@ properties: >>>>>>>>> - const: google,hoglin >>>>>>>>> - const: qcom,sc7280 >>>>>>>>> + - description: Qualcomm Technologies, Inc. sc7280 CRD Pro >>>>>>>>> platform (newest rev) >>>>>>>>> + items: >>>>>>>>> + - const: google,zoglin-sku1536 >>>>>>>>> + - const: google,hoglin-sku1536 >>>>>>>> >>>>>>>> Is there actually such a thing as a 'hoglin-sku1536', i.e. the Pro >>>>>>>> qcard >>>>>>>> with 64MB of SPI flash, or do they all have 8MB of flash? >>>>>>> >>>>>>> The SPI flash is on the CRD mother-board and not on the qcards, so if >>>>>>> you replace >>>>>>> the qcards on the CRDs with 64MB flash you would need the >>>>>>> hoglin-sku1536 to >>>>>>> boot on those. >>>>>> >>>>>> With such a configuration how does the bootloader know it should pass >>>>>> the kernel >>>>>> the device tree for 'hoglin-sku1536' (pro) and not the non-pro >>>>>> variant? IIUC the >>>>>> device tree is selected based on pin strappings on the mother-board, >>>>>> not the >>>>>> qcard. >>>>> >>>>> The device tree is selected based on the pin strappings _and_ additional >>>>> logic >>>>> to dynamically identify modem/non-modem(wifi) as well as pro/non-pro >>>>> SKUs which >>>>> was added in the bootloaders. >>>> >>>> Just to clarify things, when you mention pro SKU, is it a separate SoC >>>> revision (like sc7280-pro vs bare sc7280), or is it a CRD revision (CRD >>>> Pro vs bare CRD)? >>> >>> I guess Rajendra never responded, but since I know the answer: it's a Thanks Doug for the clarifications, I seem to have missed responding to this once I was back from vacation, >>> different SoC revision. ...but the SoC in this case is on a daughter >>> card, so you could remove the daughter card containing the SoC and put >>> a new daughtercard on. That would have the effect of making an old CRD >>> revision have the new Pro SKU SoC. >> >> So, this is a new SoC. Is it 100% compatible with the sc7280? In other >> words: does it require any additional customizations (in OPP tables, in >> frequences, speed bins, etc)? Yes, the OPP differences are taken care of with no changes needed in kernel. We describe a superset of *all* OPPs supported by a SoC family in DT and the cpufreq driver then queries the firmware for supported OPPs on a given SoC variant and ends up disabling the rest. > > If I understand correctly, the OPP customizations have been accounted > for since the beginning. I believe that the GPU operating table > already has some fairly high operating points. Maybe commit > 3bfef00d7671 ("arm64: dts: qcom: sc7280: Support gpu speedbin") was > for pro? Similarly, the CPU operating table also has some fairly high > operating points (probably for PRO?) and I think the higher points are > dynamically disabled for CPUs that don't support them. That's how it > was on sc7180, in any case. > > ...I will say it's not 100% compatible, though. Patch #2 in this > series deletes "vreg_s9c_0p676" on pro SKUs. As far as I know, that's > the only needed change, though. > > -Doug