From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFDEF36E470 for ; Tue, 16 Jun 2026 14:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781620658; cv=none; b=uVf9Ry2Z84P/PxaZxj/XzhTlj/4yADepPoPAt9QhI0qRtru7MsLPgyBvxpeX/3P5daWrI6GkuITkU322xF4DCr+OYkGv6FbWjzfmYSJrEFLHJUG/cTLOoiLBgu8Dsqyx2W2oX6z/j6U7vwfFNZDmXn2XrC9GwCBL9Ww/qPqyei8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781620658; c=relaxed/simple; bh=FfugnIQHm5unZ1sPR1Y/dZuhbcMyf+Hu3CPQK9MdeHE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GtkMPRtboAE1co51NgXqcDsmpQ5jI446ddYnFXzyHPywdH44Y3f01q7IrcUnEnZk4WpvLqMYWpsjDpAKZ3ukXQJ+g0o8w5E80gCeWbnWZIiSokWO8IDUXiICRpZLmOht4S9U6OArEwGH/OgkyHYnL7HWlzpo1TUTd9H7d8rmgI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LD6KhlVl; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LD6KhlVl" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490b64c8311so45825515e9.3 for ; Tue, 16 Jun 2026 07:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781620655; x=1782225455; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=j5+URZt3Wu1iRceLE2DPySkKJNC2rK90kTRHgoMPIB8=; b=LD6KhlVlHlwayDjDAR7n7v6Y4dplTfNFAimIfTXZLXetf3revKu7W/sGFuDAe9JAb9 Z6SfCwrYCI50699JAjL10HwWrGQhnZ2jan8dh0jyVGY6CLpixBZL0ZN3UvGb/0R5ooD2 8trGIoCX3YFzOHSj64taYDS62KbPiA0flRYHVZx6jxewInu9F53dLj69nfM2YzriQdRU BVSO222j71YZ5hirvvWlC1sH2d7u8S8YXJW+Y1Qtx8vVlihOe2VO+vU2uI6OYbiKKCWo StAyqvtj+Cf0BhWWvCaeekXK7Y9P2Gd+2CluXmt9WfmWKZ1RVjuAQU2EgjMWrZUXSUcd qTHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781620655; x=1782225455; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j5+URZt3Wu1iRceLE2DPySkKJNC2rK90kTRHgoMPIB8=; b=MJyzn4jMnFuFc6XlRJCHJ2BDtxffplyQ6sodLC2kUx3+zzqLw8hy88ThpIMnU0+LfM renO06/QlTbrAT2H/AkPnsvwYrpEcICgteAX1QiNBxjw6y1/mD9shTwH/K2Z4Y/3q6rF miA4484JyzrcDyD0sj3nqxcTkGkX7TACxQgrSsP7lW0Ok1CmPtrJM18lzRZWEPa3EWRw S4tzYTMhp3rMQHG1aibo0oRjv8NMKnDheCBGVa117T/GGpmZ3QpZBqM/d7pQmD7qYejd 7Fa6CHLalfc+KtGfbX0zpFhMdL5/5fG8GH5TGyyQUYJcYNC81QDVhdoba6r4cQSepGIh tIyA== X-Forwarded-Encrypted: i=1; AFNElJ9XN87HKi7sH3BerdPNK3zsVl+19QFYlN0ygpzBOdNuZ6jJHJ5o+J5gk3Sz2uDNZDN1ECOBwAQg7HEmd2M=@vger.kernel.org X-Gm-Message-State: AOJu0YzFfw/y0LP30boz7A1/kUONWW01IPVHLKCBL6se1Z32xlMy9zB4 LQdcPnHPB2HeW6iZDjv7ewQO6mMk/rRBzmKet1PiOJXvZrT+/ECQXNh4 X-Gm-Gg: Acq92OFwhgmwwnepYcW/VIW2X0PMZkUhC59+tb4UebdK6OwYquMt3E4X13lw5NE2h3H IBoGQOE2DbKNRQChQPAWvcyTY3Ez1PvPnxK8afTvykgLORCGdgkcsPrjV6B9NAt8bsvDcWz55XP ka+GZjI4Z+wPb5T1984ub8r+qEi3FGxKKPl86LYskP+0W5uE4/ebZ7F+5bq17yts6nHkpRUn2Ad +QRqS2Uzk584UuZIS41paGDCDQs7n2nJ+Eoz7VMhzQN/eUvSvSd18V8hLQbaOFFX+djlMbLFmrR oa35te7XHI33HgTf7jbw4kxfeTF6o6MRL9oeaVhuwo0qngqBX2t91q4aRDUdLC/ZPvT9SIEv2dP fIr+h+83R0LRch3MRcHqOaZMr9D1gS9l3HHfrPjOIpHva8sqQUMdzpfFbp0afSHjbZi28fSR5VL HGrPffo2M4m8tFYF/z9ujqzPHBxIhYfaG+6WkCe7z9Bes2Na55caq+2RNIz2mlldnEijkW1N6/p K9Eq7oQH2J4mYiE3yZDokV9rGyUTQ== X-Received: by 2002:a05:600c:3543:b0:492:3071:1db7 with SMTP id 5b1f17b1804b1-49230711dc1mr53184075e9.28.1781620655013; Tue, 16 Jun 2026 07:37:35 -0700 (PDT) Received: from [10.128.10.215] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-461eaa0d1c7sm1813947f8f.7.2026.06.16.07.37.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 07:37:34 -0700 (PDT) Sender: Julian Braha Message-ID: <18c34b11-04eb-4e01-aad2-8c18fbe26efa@gmail.com> Date: Tue, 16 Jun 2026 15:37:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] input: misc: Add Qualcomm SPMI PMIC haptics driver To: Fenglin Wu , linux-arm-msm@vger.kernel.org, Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Stephen Boyd , Bjorn Andersson , Konrad Dybcio Cc: David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , kernel@oss.qualcomm.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260616-qcom-spmi-haptics-v1-0-d24e422de6b4@oss.qualcomm.com> <20260616-qcom-spmi-haptics-v1-3-d24e422de6b4@oss.qualcomm.com> Content-Language: en-US From: Julian Braha In-Reply-To: <20260616-qcom-spmi-haptics-v1-3-d24e422de6b4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Fenglin, On 6/16/26 11:08, Fenglin Wu wrote: > +config INPUT_QCOM_SPMI_HAPTICS > + tristate "Qualcomm SPMI PMIC haptics support" > + depends on INPUT && MFD_SPMI_PMIC The dependency on INPUT is unnecessary, all config options in this Kconfig file already depend on INPUT due to an 'if INPUT..endif' in drivers/input/Kconfig (Yes, a few of the other config options in this file also have this duplicate dependency on INPUT due to an explicit 'depends on' attribute, but this file is in need of a cleanup.) - Julian Braha